Skip to content

Commit

Permalink
Merge pull request #65 from technocreatives/fix/duplicate-name
Browse files Browse the repository at this point in the history
fix duplicate enum names on multiplex messages
  • Loading branch information
linusharberg authored Feb 6, 2024
2 parents 8fcb8ca + 606159f commit 62d325a
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1145,7 +1145,7 @@ fn multiplex_enum_name(msg: &Message, multiplexor: &Signal) -> Result<String> {
multiplexor
);
Ok(format!(
"{}{}",
"{}{}Index",
msg.message_name().to_pascal_case(),
multiplexor.name().to_pascal_case()
))
Expand Down
16 changes: 8 additions & 8 deletions testing/can-messages/src/messages.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1182,14 +1182,14 @@ impl MultiplexTest {
u8::from(signal).saturating_mul(factor).saturating_add(0)
}

pub fn multiplexor(&mut self) -> Result<MultiplexTestMultiplexor, CanError> {
pub fn multiplexor(&mut self) -> Result<MultiplexTestMultiplexorIndex, CanError> {
match self.multiplexor_raw() {
0 => Ok(MultiplexTestMultiplexor::M0(MultiplexTestMultiplexorM0 {
raw: self.raw,
})),
1 => Ok(MultiplexTestMultiplexor::M1(MultiplexTestMultiplexorM1 {
raw: self.raw,
})),
0 => Ok(MultiplexTestMultiplexorIndex::M0(
MultiplexTestMultiplexorM0 { raw: self.raw },
)),
1 => Ok(MultiplexTestMultiplexorIndex::M1(
MultiplexTestMultiplexorM1 { raw: self.raw },
)),
multiplexor => Err(CanError::InvalidMultiplexor {
message_id: 200,
multiplexor: multiplexor.into(),
Expand Down Expand Up @@ -1313,7 +1313,7 @@ impl<'a> Arbitrary<'a> for MultiplexTest {
}
/// Defined values for multiplexed signal MultiplexTest
#[derive(Debug)]
pub enum MultiplexTestMultiplexor {
pub enum MultiplexTestMultiplexorIndex {
M0(MultiplexTestMultiplexorM0),
M1(MultiplexTestMultiplexorM1),
}
Expand Down
4 changes: 2 additions & 2 deletions testing/can-messages/tests/all.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#![allow(clippy::float_cmp)]

use can_messages::{
Amet, Bar, BarThree, CanError, Foo, MultiplexTest, MultiplexTestMultiplexor,
Amet, Bar, BarThree, CanError, Foo, MultiplexTest, MultiplexTestMultiplexorIndex,
MultiplexTestMultiplexorM0,
};

Expand Down Expand Up @@ -69,7 +69,7 @@ fn pack_unpack_message_containing_multiplexed_signals() {
assert_eq!(result.unmultiplexed_signal(), 2);
assert_eq!(result.multiplexor_raw(), 0);
let multiplexor = result.multiplexor().unwrap();
if let MultiplexTestMultiplexor::M0(m0) = multiplexor {
if let MultiplexTestMultiplexorIndex::M0(m0) = multiplexor {
assert_eq!(m0.multiplexed_signal_zero_a(), 1.2);
assert_eq!(m0.multiplexed_signal_zero_b(), 2.0);
} else {
Expand Down

0 comments on commit 62d325a

Please sign in to comment.