Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verify config: Playbook verify_config.yml included in site.yml #385

Closed
wants to merge 6 commits into from
Closed

verify config: Playbook verify_config.yml included in site.yml #385

wants to merge 6 commits into from

Conversation

edoziw
Copy link

@edoziw edoziw commented Oct 19, 2023

… README.md with config verifications for ip routing prefix and metal_lb_ip_range checks etc

Proposed Changes

For issue #377

  • README.md (doc for these changes)
  • site.yml (imports verify_config.yml)
    • verify_config.yml (uses these two roles)
      • roles/verify_config (on each host: gathers facts and asserts per host)
      • roles/verify_config_gather (on localhost: checks gathered facts are the same for each host )

Checklist

  • [ x ] Tested locally
  • [ x ] Ran site.yml playbook
  • Ran reset.yml playbook (no impact)
  • [ x ] Did not add any unnecessary changes
  • [ x ] Ran pre-commit install at least once before committing
  • [ x ] 🚀

Thanks Tim
Odeziw

kip added 2 commits October 19, 2023 18:14
Added verify_config.yml playbook and included it in site.yml, Updated…
fe4407d 
… README.md with config verifications for ip routing prefix and metal_lb_ip_range checks etc
fixed newline
13deec8
timothystewart6
timothystewart6 reviewed Oct 20, 2023
View reviewed changes
roles/verify_config_gather/filter_plugins/__pycache__/range_to_ips.cpython-310.pyc Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to include this binary?

Copy link
Author

@edoziw edoziw Oct 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, I missed that, I thought __pycache__ was in the .gitignore
I'll fix .gitignore and also git rm --cached <the file> then push

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok now.
Sorry about that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@edoziw edoziw changed the title Verify Verify config playbook Oct 22, 2023
@edoziw edoziw changed the title Verify config playbook Verify config playbook included in site.yml Oct 22, 2023
@edoziw edoziw changed the title Verify config playbook included in site.yml verify config: Playbook verify_config.yml included in site.yml Oct 23, 2023
@timothystewart6
Copy link
Contributor

Thank you!

@timothystewart6 timothystewart6 enabled auto-merge (squash) October 25, 2023 04:32
@timothystewart6
Copy link
Contributor

It looks like CI is failing with this PR

see here:

@timothystewart6
Copy link
Contributor

timothystewart6 commented Feb 9, 2024 •
edited
Loading

Going to close this. If tests are fixed feel free to reopen this!

auto-merge was automatically disabled February 9, 2024 22:10

Pull request was closed

@timothystewart6
Copy link
Contributor

related issue is here #377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothystewart6 timothystewart6 timothystewart6 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edoziw @timothystewart6