Skip to content

Commit

Permalink
fix: plat-6457 tfs tags are added to the stack instead of the app (#69)
Browse files Browse the repository at this point in the history
  • Loading branch information
juan-casimiro authored Apr 18, 2023
1 parent 3fc5e48 commit 75c40b0
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions lib/talis-cdk-stack/talis-cdk-stack.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ export class TalisCdkStack extends Stack {
this.vpc = this.resolveVpc(props.vpcId);
}

cdk.Tags.of(scope).add("tfs-app", props.app); // e.g. depot
cdk.Tags.of(scope).add("tfs-environment", props.deploymentEnvironment); // e.g. production staging development
cdk.Tags.of(scope).add("tfs-release", props.release); // e.g. 8561-105814f
cdk.Tags.of(this).add("tfs-app", props.app); // e.g. depot
cdk.Tags.of(this).add("tfs-environment", props.deploymentEnvironment); // e.g. production staging development
cdk.Tags.of(this).add("tfs-release", props.release); // e.g. 8561-105814f

// props.env comes from aws cdk core StackProps. It's optional
// so that an environment agnostic stack can be created.
Expand All @@ -32,7 +32,7 @@ export class TalisCdkStack extends Stack {
`Cannot resolve a tfs-region for props.env.region: '${props.env.region}'`
);
}
cdk.Tags.of(scope).add("tfs-region", talisShortRegion);
cdk.Tags.of(this).add("tfs-region", talisShortRegion);
let tfsService;
if (
props.deploymentEnvironment === TalisDeploymentEnvironment.PRODUCTION
Expand All @@ -42,7 +42,7 @@ export class TalisCdkStack extends Stack {
tfsService = `${props.app}-${props.deploymentEnvironment}-${talisShortRegion}`;
}

cdk.Tags.of(scope).add("tfs-service", tfsService);
cdk.Tags.of(this).add("tfs-service", tfsService);
}
}

Expand Down

0 comments on commit 75c40b0

Please sign in to comment.