[FEAT/#328] 탐색 뷰 / 페이징 추가 #329
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeeyubin
approved these changes
Jan 11, 2025
Comment on lines
12
to
+14
| // domain | ||
| implementation(projects.domain.search) | ||
| implementation(libs.androidx.paging.common.android) |
There was a problem hiding this comment.
사소한거긴한데,, 모듈에 대한 의존성이랑 구분하기 위해서 한 줄 띄워주면 좋을 것 가타요 ㅎㅎ
There was a problem hiding this comment.
그리고 implementation(libs.androidx.paging.common.android) 이건 새로 추가된 라이브러리 같은데 기존에 있었던 라이브러리로는 대체 불가능한가요...?!
Comment on lines
+27
to
+31
| ): Flow<PagingData<SearchResult>> { | ||
| return Pager( | ||
| PagingConfig(pageSize = 100) | ||
| ) { | ||
| SearchPagingSource( |
There was a problem hiding this comment.
여기서 pageSize가 한 번 로딩할 때 불러올 아이템 수를 지정하는 거 맞죠?!
홈은 10개로 통일했었는데 검색도 10개로 가야 할 것 같아요..!
Comment on lines
+190
to
+191
| androidx-constraintlayout-core = { group = "androidx.constraintlayout", name = "constraintlayout-core", version.ref = "constraintlayoutCore" } | ||
| androidx-constraintlayout = { group = "androidx.constraintlayout", name = "constraintlayout", version.ref = "constraintlayout" } |
There was a problem hiding this comment.
이 두 라이브러리가 사용되는 곳을 못 본 것 같은데 추가해준 이유가 있나용..?
Comment on lines
+5
to
+8
| dependencies { | ||
| implementation(libs.paging.common) | ||
| implementation(libs.coroutines.core) | ||
| implementation(libs.coroutines.test) |
There was a problem hiding this comment.
그리구 이 부분은 :domain:home 모듈이랑 같은 것 같긴한데 implementation(libs.coroutines.test)는 테스트 코드를 작성하지 않은 상태라 필요 없지 않을까요...?
추가해준 의도가 있는지 궁금합니당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
328.mp4
📢 To Reviewers