Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE/#447] target sdk 34 #448

Merged
merged 4 commits into from
Jul 19, 2024
Merged

[CHORE/#447] target sdk 34 #448

merged 4 commits into from
Jul 19, 2024

Conversation

kkk5474096
Copy link
Contributor

⛳️ Work Description

  • target sdk 34 상향
  • 그에 따른 onDraw nullable -> not null 타입 변경
  • 자바 VERSION 17 -> 18 상향

📢 To Reviewers

  • 테스트 부탁~ 드립니다.
  • 저는 정상작동 확인했습니다

@kkk5474096 kkk5474096 added CHORE 🎀 버전 코드 수정, 패키지 구조 변경, 타입 및 변수명 변경 등의 작은 변경 강민 🦖 Kangmin's Task labels Jul 18, 2024
@kkk5474096 kkk5474096 self-assigned this Jul 18, 2024
@kkk5474096 kkk5474096 requested a review from a team as a code owner July 18, 2024 09:23
Marchbreeze
Marchbreeze approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@Marchbreeze Marchbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사함니둥 ㅎㅎ
버전업 한다음에 이슈 생기는 라이브러리 버전들 수정해주면 되는 과정인가여?

@kkk5474096 kkk5474096 changed the title Chore/#447 target sdk 34 [CHORE/#447] target sdk 34 Jul 19, 2024
@b1urrrr
Copy link
Member

b1urrrr commented Jul 19, 2024

아빠최고

@kkk5474096 kkk5474096 merged commit 58cc469 into develop Jul 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marchbreeze Marchbreeze Marchbreeze approved these changes

Assignees

@kkk5474096 kkk5474096

Labels
CHORE 🎀 버전 코드 수정, 패키지 구조 변경, 타입 및 변수명 변경 등의 작은 변경 강민 🦖 Kangmin's Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CHORE] TARGET SDK 34 상향
3 participants
@kkk5474096 @b1urrrr @Marchbreeze