Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX/#435] 상점 관련 Amplitude 수정 및 중학교 userProperties 추가 #436

Merged
merged 7 commits into from
Apr 6, 2024
Merged

[FIX/#435] 상점 관련 Amplitude 수정 및 중학교 userProperties 추가 #436

merged 7 commits into from
Apr 6, 2024

Conversation

minju1459
Copy link
Contributor

@minju1459 minju1459 commented Apr 5, 2024 •
edited
Loading

⛳️ Work Description

  • 내 옐로뷰 Amplitude 수정
  • 중/고등학교 구분 userProperties 추가
  • Amplitude 모든뷰 상수화
  • 오류 메시지 수정

📸 Screenshot

📢 To Reviewers

  • 내 옐로뷰 경우의 수가 정말 많네요 ..ㅎ
  • �Amplitude로 확인까지 완료 !

@minju1459 minju1459 added ADD ➕ 부수적인 코드 추가 및 라이브러리 추가, 새로운 파일 생성 FIX 🔨 버그 및 오류 해결 PULL REQUEST 🚀 pull reqeust 날리기 민주 🌳 Minju's Task labels Apr 5, 2024
@minju1459 minju1459 added this to the 3차 스프린트 QA milestone Apr 5, 2024
@minju1459 minju1459 self-assigned this Apr 5, 2024
@minju1459 minju1459 requested a review from a team as a code owner April 5, 2024 05:05
Marchbreeze
Marchbreeze approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@Marchbreeze Marchbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생햇숴요~~

@minju1459 minju1459 merged commit 07dcd9f into develop Apr 6, 2024
1 check passed
@minju1459 minju1459 deleted the fix/#435-shop-amplitude branch April 6, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marchbreeze Marchbreeze Marchbreeze approved these changes

Assignees

@minju1459 minju1459

Labels
ADD ➕ 부수적인 코드 추가 및 라이브러리 추가, 새로운 파일 생성 FIX 🔨 버그 및 오류 해결 PULL REQUEST 🚀 pull reqeust 날리기 민주 🌳 Minju's Task
Projects
YELL:O ANDROID
Status: Done
Milestone
3차 스프린트 QA
Development

Successfully merging this pull request may close these issues.

[FIX] 상점 관련 Amplitude 수정
2 participants
@minju1459 @Marchbreeze