Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT/#419] 푸시 알림(FCM) 추가 구현 #422

Merged
merged 9 commits into from
Mar 3, 2024

Conversation

minju1459
Copy link
Contributor

@minju1459 minju1459 commented Mar 2, 2024

⛳️ Work Description

  • 점심시간 이벤트 (매일 12시)
    → 서버에서 12-14시에만 점심시간 이벤트가 뜨도록 보내주므로 시간에 관계없이 알림 클릭 후 그냥 앱 진입, 따로 처리 X
  • 추천인 가입 (열람권 지급)
    → 내 쪽지
  • 누군가 내가 보낸 쪽지를 열람할 때
    → 타임라인 (내가 보낸 쪽지)
  • manifest 불필요한 권한 삭제

📸 Screenshot

점심시간 이벤트 첫 추천인 가입 (열람권 지급) 누군가 내가 보낸 쪽지 열람 시

📢 To Reviewers

  • @team-yello/andro-d
  • 알림 클릭 시 화면 전환 다 확인했습니당

@minju1459 minju1459 added FEAT ✨ 새로운 기능 구현 PULL REQUEST 🚀 pull reqeust 날리기 민주 🌳 Minju's Task labels Mar 2, 2024
@minju1459 minju1459 added this to the 3차 스프린트 개발 milestone Mar 2, 2024
@minju1459 minju1459 self-assigned this Mar 2, 2024
@minju1459 minju1459 requested a review from a team as a code owner March 2, 2024 08:48
Copy link
Member

@b1urrrr b1urrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿티비~~ 안드막내민주최고~~~

}
PUSH_TYPE_OPEN_VOTE -> {
binding.bnvMain.menu.getItem(1).isChecked = true
val bundle = Bundle().apply { putBoolean("isFilterSelected", true) }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

상수화 해줘도 좋을 것 같아요!!

@@ -41,14 +41,15 @@ class TimelineFragment : BindingFragment<FragmentTimelineBinding>(R.layout.fragm
private var isScrolled: Boolean = false
private var isNoFriend: Boolean = false

private var isFilterSelected: Boolean = false
var isFilterSelected: Boolean = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 private 지우신 이유가 먼가요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 요거 isFilterSelected를 알림 클릭 시 true로 바꿔주는거 다른 방식으로 구현했다가 다시 안돌려놨네요 다시 올릴겠습니당

Copy link
Member

@Marchbreeze Marchbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔꼼하네요!

@@ -9,13 +9,8 @@
<uses-permission android:name="com.google.android.gms.permission.AD_ID" />
<uses-permission android:name="com.google.android.play.billingclient.version" />
<uses-permission android:name="com.android.vending.BILLING" />
<uses-permission android:name="android.permission.READ_PHONE_STATE" />
<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />
<uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" />
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요 친구는 필요한건가요 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

현재는 외부 저장소 파일을 가져와서 쓰는 경우는 없으니 일단 지워둘게요 ~~

@minju1459 minju1459 merged commit 180c264 into develop Mar 3, 2024
1 check passed
@minju1459 minju1459 deleted the feat/#419-3rd-sprint-fcm-add branch March 3, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FEAT ✨ 새로운 기능 구현 PULL REQUEST 🚀 pull reqeust 날리기 민주 🌳 Minju's Task
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEAT] 푸시 알림(FCM) 추가 구현
3 participants