-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT/#419] 푸시 알림(FCM) 추가 구현 #422
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굿굿티비~~ 안드막내민주최고~~~
} | ||
PUSH_TYPE_OPEN_VOTE -> { | ||
binding.bnvMain.menu.getItem(1).isChecked = true | ||
val bundle = Bundle().apply { putBoolean("isFilterSelected", true) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
상수화 해줘도 좋을 것 같아요!!
@@ -41,14 +41,15 @@ class TimelineFragment : BindingFragment<FragmentTimelineBinding>(R.layout.fragm | |||
private var isScrolled: Boolean = false | |||
private var isNoFriend: Boolean = false | |||
|
|||
private var isFilterSelected: Boolean = false | |||
var isFilterSelected: Boolean = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
혹시 private 지우신 이유가 먼가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 요거 isFilterSelected를 알림 클릭 시 true로 바꿔주는거 다른 방식으로 구현했다가 다시 안돌려놨네요 다시 올릴겠습니당
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
깔꼼하네요!
app/src/main/AndroidManifest.xml
Outdated
@@ -9,13 +9,8 @@ | |||
<uses-permission android:name="com.google.android.gms.permission.AD_ID" /> | |||
<uses-permission android:name="com.google.android.play.billingclient.version" /> | |||
<uses-permission android:name="com.android.vending.BILLING" /> | |||
<uses-permission android:name="android.permission.READ_PHONE_STATE" /> | |||
<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" /> | |||
<uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" /> | |||
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요 친구는 필요한건가요 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
현재는 외부 저장소 파일을 가져와서 쓰는 경우는 없으니 일단 지워둘게요 ~~
⛳️ Work Description
→ 서버에서 12-14시에만 점심시간 이벤트가 뜨도록 보내주므로 시간에 관계없이 알림 클릭 후 그냥 앱 진입, 따로 처리 X
→ 내 쪽지
→ 타임라인 (내가 보낸 쪽지)
📸 Screenshot
📢 To Reviewers