Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX/#414] Timeline, Pay / 3차 스프린트 3차 QA 피드백 반영 #416

Merged
merged 10 commits into from
Feb 26, 2024
Merged

[FIX/#414] Timeline, Pay / 3차 스프린트 3차 QA 피드백 반영 #416

merged 10 commits into from
Feb 26, 2024

Conversation

Marchbreeze
Copy link
Member

@Marchbreeze Marchbreeze commented Feb 24, 2024 •
edited
Loading

⛳️ Work Description

  • 광고 보고난 후 리워드 다이얼로그 이미지 변경
  • "내가 보낸 쪽지" 필터의 엠프티뷰 라이팅 변경
  • 미사용 drawable 정리
  • ic 와 img 구분
  • shape 네이밍 통일

📸 Screenshot

📢 To Reviewers

  • QA 겸, 이미지랑 shape 네이밍 통일하고 안쓰는 것들 다 정리해버렸슴니다 ~
  • 안쓰던... 친구들이 많더라구요

@Marchbreeze Marchbreeze added FIX 🔨 버그 및 오류 해결 PULL REQUEST 🚀 pull reqeust 날리기 REFACTOR ♻️ 전면 수정 상호 🍀 Sangho's Task labels Feb 24, 2024
@Marchbreeze Marchbreeze added this to the 3차 스프린트 QA milestone Feb 24, 2024
@Marchbreeze Marchbreeze self-assigned this Feb 24, 2024
@Marchbreeze Marchbreeze requested a review from a team as a code owner February 24, 2024 12:44
@Marchbreeze Marchbreeze changed the title [FIX] Timeline, Pay / 3차 스프린트 3차 QA 피드백 반영 [FIX/#414] Timeline, Pay / 3차 스프린트 3차 QA 피드백 반영 Feb 24, 2024
minju1459
minju1459 approved these changes Feb 24, 2024
View reviewed changes
Copy link
Contributor

@minju1459 minju1459 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넘 깔꼼하네요 .... 😇 항상 디테일 감사합니더 ~~

b1urrrr
b1urrrr approved these changes Feb 24, 2024
View reviewed changes
Copy link
Member

@b1urrrr b1urrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿~~

@Marchbreeze Marchbreeze merged commit d452ac1 into develop Feb 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minju1459 minju1459 minju1459 approved these changes

@b1urrrr b1urrrr b1urrrr approved these changes

Assignees

@Marchbreeze Marchbreeze

Labels
FIX 🔨 버그 및 오류 해결 PULL REQUEST 🚀 pull reqeust 날리기 REFACTOR ♻️ 전면 수정 상호 🍀 Sangho's Task
Projects
YELL:O ANDROID
Status: Done
Milestone
3차 스프린트 QA
Development

Successfully merging this pull request may close these issues.

[FIX] Timeline, Pay / 3차 스프린트 3차 QA 피드백 반영
3 participants
@Marchbreeze @b1urrrr @minju1459