Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT/#372] Profile / 프로필 배너 설정 #375

Merged
merged 7 commits into from
Feb 7, 2024

Conversation

Marchbreeze
Copy link
Member

⛳️ Work Description

  • 프로필 배너 설정
  • 배너 observe 이후 친구 리스트 추가

📸 Screenshot

📢 To Reviewers

  • 멀티뷰타입이라 쬐끔 걸렷서요
  • 프로필 배너가 저 사진으로 와서 ... 나중에 높이 작은 프로필 배너로 왔을 떄 문제 있으면 다시 건드리겟슴ㄷㅏ ..

@Marchbreeze Marchbreeze added FEAT ✨ 새로운 기능 구현 PULL REQUEST 🚀 pull reqeust 날리기 상호 🍀 Sangho's Task labels Feb 6, 2024
@Marchbreeze Marchbreeze added this to the 3차 스프린트 개발 milestone Feb 6, 2024
@Marchbreeze Marchbreeze self-assigned this Feb 6, 2024
@Marchbreeze Marchbreeze requested a review from a team as a code owner February 6, 2024 18:52
Copy link
Contributor

@minju1459 minju1459 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠르시군요 ~~~ ! LGTM~~!!


if (viewModel.profileBanner.isAvailable) {
binding.ivProfileBanner.load(viewModel.profileBanner.imageUrl)
binding.ivProfileBanner.setOnSingleClickListener { bannerClick(viewModel.profileBanner.redirectUrl) }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coil 사용 좋네요 ~~~!

android:layout_height="wrap_content"
android:layout_marginHorizontal="16dp"
android:layout_marginTop="10dp"
android:adjustViewBounds="true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 이거 이미지 비율 맞추는 거군요 ~~!

@Marchbreeze Marchbreeze merged commit 5d91aab into develop Feb 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FEAT ✨ 새로운 기능 구현 PULL REQUEST 🚀 pull reqeust 날리기 상호 🍀 Sangho's Task
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEAT] Profile / 프로필 뷰 배너 구현
2 participants