Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI/#368] MyYello / 스토리 공유 버튼 강조 #369

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

b1urrrr
Copy link
Member

@b1urrrr b1urrrr commented Feb 2, 2024

⛳️ Work Description

  • 스토리 공유 버튼 강조

📸 Screenshot

📢 To Reviewers

  • 뷰만 조금 수정해서 PR 크기가 굉장히 작은데 1순위라 일단 올려놓습니다!
  • 깃이 이상해졋어요... 머지 전에 고쳐놓을게요!

@b1urrrr b1urrrr added PULL REQUEST 🚀 pull reqeust 날리기 UI 💐 UI 작업 채연 🐸 Chaeyeon's Task labels Feb 2, 2024
@b1urrrr b1urrrr added this to the 3차 스프린트 개발 milestone Feb 2, 2024
@b1urrrr b1urrrr self-assigned this Feb 2, 2024
@b1urrrr b1urrrr requested a review from a team as a code owner February 2, 2024 13:31
Copy link
Member

@Marchbreeze Marchbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

조하요~

Comment on lines 113 to 116
background = ContextCompat.getDrawable(
context,
R.drawable.shape_yello_main_500_fill_500_botshadow_rect,
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요친구도 확장함수 중에 drawableOf() 활용하면 ContextCompat 없이도 할수있아요~

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

꿀팁 감삼다!! 확장함수 최고!!!

@b1urrrr b1urrrr closed this Feb 4, 2024
@b1urrrr b1urrrr reopened this Feb 4, 2024
@b1urrrr b1urrrr force-pushed the ui/#368-modify-story-share-button branch from f5cedbe to 05685ab Compare February 4, 2024 19:00
@b1urrrr b1urrrr force-pushed the ui/#368-modify-story-share-button branch from eabfb60 to 0597561 Compare February 5, 2024 10:06
@b1urrrr b1urrrr merged commit 09b3a25 into develop Feb 5, 2024
1 check passed
@b1urrrr b1urrrr deleted the ui/#368-modify-story-share-button branch February 5, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PULL REQUEST 🚀 pull reqeust 날리기 UI 💐 UI 작업 채연 🐸 Chaeyeon's Task
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[UI] MyYello / 스토리 공유 버튼 강조
2 participants