Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT/#344] 추천 친구 뷰 / 프로필 추가 #347

Merged
merged 15 commits into from
Jan 24, 2024
Merged

[FEAT/#344] 추천 친구 뷰 / 프로필 추가 #347

merged 15 commits into from
Jan 24, 2024

Conversation

minju1459
Copy link
Contributor

@minju1459 minju1459 commented Jan 21, 2024 •
edited
Loading

⛳️ Work Description

  • 프로필 바텀시트 UI 구현
  • (update) 특정 유저 조회 API 연결
  • 내 정보 조회하기 v2 dto 수정 반영
  • 바텀시트 로직 연결
  • 바텀시트 버튼 - 친구 추가 로직 연결
  • 친구 추가 -> check -> bottomsheet dimiss

📸 Screenshot

📢 To Reviewers

  • @team-yello/andro-d
  • BottomSheet나 서버 통신 함수들의 재사용성을 위해 KakaoViewmodel, SchoolViewmodel을 한번에 관리해보려 했는데
    각각의 fragment에서 viewmodel이 공유되면 중복 호출 등의 문제가 발생하여 다시 분리했습니당 !

minju1459 added 14 commits January 4, 2024 23:08
@minju1459
[FEAT/#344] 추천친구뷰 BottomSheet
dd52acd
@minju1459
[FEAT/#344] 내 정보 조회하기 dto 수정 반영
a15a474
@minju1459
[FIX/#344] 유저 정보 조회 url 변경 및 dto 수정
9d3b731
@minju1459
[FIX/#344] userId type int -> Long
7d67c33
@minju1459
[MOD/#344] ktlint
f2602bc
@minju1459
[FEAT/#344] 추천친구 카카오 프로필 로직 연결
7c9e1ce
@minju1459
[FEAT/#344] 특정 유저 정보 조회 서버 통신 구현
c047a05
@minju1459
[FEAT/#344] 프로필 바텀시트 로직 연결
5476fcb
@minju1459
[ADD/#344] 친구추가 버튼 클릭 시 체크 표시 후 dismiss
0c8e182
@minju1459
[MOD/#344] kakao,school viewmodel combine
2a67e85
@minju1459
[FEAT/#344] bottomsheet 친추 버튼 클릭 시에만 친추 서버 통신
fc699db
@minju1459
[DEL/#344] itemclick -> addFriendToServer() 삭제
4265c4d
@minju1459
[MOD/#344] kakao,school viewmodel 다시 분리
3c2a2bc
@minju1459
[FEAT/#344] bottomsheet button 클릭 시 친구 추가, removeItem
c891ef3
@minju1459 minju1459 added FEAT ✨ 새로운 기능 구현 PULL REQUEST 🚀 pull reqeust 날리기 민주 🌳 Minju's Task labels Jan 21, 2024
@minju1459 minju1459 added this to the 3차 스프린트 개발 milestone Jan 21, 2024
@minju1459 minju1459 self-assigned this Jan 21, 2024
@minju1459 minju1459 requested a review from a team as a code owner January 21, 2024 15:32
Marchbreeze
Marchbreeze approved these changes Jan 21, 2024
View reviewed changes
Copy link
Member

@Marchbreeze Marchbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아웅 좋네요 저도 슬슬 달려보겟슴둥 ㅎㅎ

@minju1459 minju1459 merged commit c4e6972 into develop Jan 24, 2024
1 check passed
@minju1459 minju1459 deleted the feat/#344-recommend-profile branch January 24, 2024 04:31
@minju1459 minju1459 changed the title [FEAT/#344] 추천 친구뷰 / 프로필 추가 [FEAT/#344] 추천 친구 뷰 / 프로필 추가 Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marchbreeze Marchbreeze Marchbreeze approved these changes

@b1urrrr b1urrrr Awaiting requested review from b1urrrr

@kkk5474096 kkk5474096 Awaiting requested review from kkk5474096

Assignees

@minju1459 minju1459

Labels
FEAT ✨ 새로운 기능 구현 PULL REQUEST 🚀 pull reqeust 날리기 민주 🌳 Minju's Task
Projects
YELL:O ANDROID
Status: Done
Milestone
3차 스프린트 개발
Development

Successfully merging this pull request may close these issues.

[FEAT] 추천친구뷰 / 프로필 추가
2 participants
@minju1459 @Marchbreeze