Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI/#326] 타임라인 뷰 UI 수정 #327

Merged
merged 9 commits into from
Nov 9, 2023
Merged

[UI/#326] 타임라인 뷰 UI 수정 #327

merged 9 commits into from
Nov 9, 2023

Conversation

Marchbreeze
Copy link
Member

@Marchbreeze Marchbreeze commented Nov 6, 2023 •
edited
Loading

⛳️ Work Description

  • 서버통신 변경 - 프로필이미지 받기
  • UI 변경
  • 이미지 삭제 & 기본 이미지 설정
  • 스켈레톤 변경
  • 내옐로뷰 이슈 수정
  • 버전 업

📸 Screenshot

2023-11-06_21-19-39

@Marchbreeze Marchbreeze added FIX 🔨 버그 및 오류 해결 PULL REQUEST 🚀 pull reqeust 날리기 상호 🍀 Sangho's Task labels Nov 6, 2023
@Marchbreeze Marchbreeze self-assigned this Nov 6, 2023
@Marchbreeze Marchbreeze requested a review from a team as a code owner November 6, 2023 12:21
@Marchbreeze Marchbreeze changed the title [UI/#326] 타입라인 뷰 UI 수정 [UI/#326] 타임라인 뷰 UI 수정 Nov 6, 2023
minju1459
minju1459 approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@minju1459 minju1459 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ~!!

b1urrrr
b1urrrr approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@b1urrrr b1urrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿티비

app/src/main/java/com/el/yello/presentation/main/look/LookViewHolder.kt
itemView.context, R.drawable.ic_yello_blue
)
)
if (item.senderGender == MALE) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MALE이랑 FEMALE 요거 enum이나 sealed class로 만들어보는 건 어때여

@Marchbreeze Marchbreeze merged commit be335f9 into develop Nov 9, 2023
1 check passed
@Marchbreeze Marchbreeze deleted the ui/#326-timeline-image branch November 9, 2023 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minju1459 minju1459 minju1459 approved these changes

@b1urrrr b1urrrr b1urrrr approved these changes

Assignees

@Marchbreeze Marchbreeze

Labels
FIX 🔨 버그 및 오류 해결 PULL REQUEST 🚀 pull reqeust 날리기 상호 🍀 Sangho's Task
Projects
YELL:O ANDROID
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] 타임라인 뷰 / UI 변경
3 participants
@Marchbreeze @b1urrrr @minju1459