-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX/#300,#302] Domain 레이어 Paging3 제거 & FlowWithLifecycle 적용 #304
Merged
Merged
Changes from 11 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
da4b141
[FIX/#302] 타임라인 뷰 Paging Repository 제거
Marchbreeze 24dff9c
[FIX/#302] 프로필 flowWithLifecycle 적용
Marchbreeze c7934c8
[FIX/#302] 추천친구 flowWithLifecycle 적용
Marchbreeze 5bc8ef4
[FIX/#302] 결제 flowWithLifecycle 적용
Marchbreeze eadfa38
[FIX/#302] 타임라인 뷰 flowWithLifecycle 적용
Marchbreeze f499543
[FIX/#302] 검색 뷰 flowWithLifecycle 적용
Marchbreeze 52ce691
[FIX/#302] 온보딩 친구추가 뷰 flowWithLifecycle 적용
Marchbreeze 6fe8431
[FIX/#302] 로그인 뷰 flowWithLifecycle 적용
Marchbreeze 5d5fbe1
[FIX/#302] 친구동의 뷰 flowWithLifecycle 적용
Marchbreeze 742187a
[FIX/#302] BillingManager 함수화 수정
Marchbreeze 3e5d302
Merge branch 'develop' of https://github.com/team-yello/YELLO-Android…
Marchbreeze e3a1e6b
[FIX/#302] 로그인 뷰 flow 검증
Marchbreeze f650378
[FIX/#302] 온보딩 친구추가 flow 검증
Marchbreeze 3592911
[FIX/#302] 프로필, 타임라인 flow 검증
Marchbreeze 07f5a0b
[FIX/#302] 추천친구 flow 검증
Marchbreeze 585b215
[FIX/#302] 검색 flow 검증
Marchbreeze 1d71ee8
[FIX/#302] 결제 flow 검증
Marchbreeze 7c2692e
[FIX/#302] 프로필 뷰 아이디 @ 고정 해제
Marchbreeze d201cba
[FIX/#302] 결제 flow 검증
Marchbreeze 527b1b0
Merge branch 'develop' of https://github.com/team-yello/YELLO-Android…
Marchbreeze File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
도메인 단에 데이터 클래스 하나 만들어서 parcelableExtra로 넘겨주면 좀 더 깔끔하지 않을까 싶은데 어떤가여 🧐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
카카오 유저 도메인 만들어서 처리하면 좋을 것 같네요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
근데 Parcelable은 android 라이브러리라서 domain에서 선언은 해주면 안되고 UiModel 새로 만들어서 파싱하거나 해야합니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
허거덩