[MOD/#266] 추천, 검색, 프로필, 결제, 타임라인 / StateFlow로 변경 #294

Marchbreeze · 2023-10-09T11:13:54Z

closed [MOD] 추천, 검색, 프로필, 결제, 타임라인 / StateFlow로 변경 #266

⛳️ Work Description

📢 To Reviewers

리팩토링 부분보다, Flow 관련 뷰모델 & 옵저버 부분쪽 자세히 봐주시고 수정 부탁드립니다 ㅜ

…into mod/#266-flow-paging3

b1urrrr

고생많으셧습니다!
리뷰하면서 많이 배워갑니둥!!

b1urrrr · 2023-10-09T19:57:34Z

app/src/main/java/com/el/yello/presentation/main/look/LookViewModel.kt

+    fun getLookListWithPaging(): Flow<PagingData<LookModel>> {
+        return lookRepository.getLookList()


Suggested change

fun getLookListWithPaging(): Flow<PagingData<LookModel>> {

return lookRepository.getLookList()

fun getLookListWithPaging(): Flow<PagingData<LookModel>> = lookRepository.getLookList()

일케도 쓸 수 잇어요

성능 상 다른 건 없고 문법의 차이만 있나요 ?

코틀린스러운 문법이죠

b1urrrr · 2023-10-09T19:58:26Z

app/src/main/java/com/el/yello/presentation/main/myyello/MyYelloFragment.kt

-                "click_go_shop",
-                JSONObject().put("shop_button", "cta_main"),
-            )
+            setClickGoShopAmplitude("cta_main")


시간 나면 상수화도 부탁드립니다!!ㅎ

앰플리튜드도 상수화 다하셨...나..요...?

원래라면 하긴합니둥

b1urrrr · 2023-10-09T19:59:33Z

app/src/main/java/com/el/yello/presentation/main/profile/ProfileViewModel.kt

@@ -35,26 +33,29 @@ class ProfileViewModel @Inject constructor(
    private val payRepository: PayRepository
 ) : ViewModel() {

-    private val _getState = MutableLiveData<UiState<ProfileUserModel>>()
-    val getState: LiveData<UiState<ProfileUserModel>> = _getState
+    private val _getUserDataState = MutableStateFlow<UiState<ProfileUserModel>>(UiState.Empty)


UiState 초기값으로는 Empty보다 Loading이 더 적합하지 않을까여?

Loading일 때 shimmer나 lottie를 적용해둔 부분이 가끔씩 있어서 ... 중복 실행 방지를 위해 아무런 로직 설정이 없는 empty로 해뒀습니닷

b1urrrr · 2023-10-09T20:02:39Z

app/src/main/java/com/el/yello/presentation/main/profile/info/ProfileFragment.kt

+        lifecycleScope.launch {
+            viewModel.getUserDataState.collectLatest { state ->
+                when (state) {


굿굿티비!

b1urrrr · 2023-10-09T20:03:34Z

app/src/main/java/com/el/yello/presentation/main/profile/info/ProfileFragment.kt

-                            && layoutManager is LinearLayoutManager
-                            && layoutManager.findLastVisibleItemPosition() == adapter.itemCount - 1
-                        ) {
+                        if (!binding.rvProfileFriendsList.canScrollVertically(1) && layoutManager is LinearLayoutManager && layoutManager.findLastVisibleItemPosition() == adapter.itemCount - 1) {


복잡해보이는데 함수화를 하는 것은 어떨까여?

b1urrrr · 2023-10-09T20:08:57Z

app/src/main/java/com/el/yello/presentation/main/recommend/school/RecommendSchoolFragment.kt

+                    is UiState.Failure -> {
+                        showShimmerScreen()
+                        yelloSnackbar(
+                            requireView(),
+                            getString(R.string.recommend_error_school_friend_connection),
+                        )
+                    }


StateFlow는 중복된 값을 처리하지 않는다고 이해했는데 그러면 두 번 연속 친구 불러오기에 실패해도 초기 한 번만 처리되지 않을까요...?

오....작동은 하던데... UiState에 담긴 모델값이 달라서 다른 값으로 인식을 했던 걸까요..?
@kkk5474096 도와줘욧
아니면 이런 경우에 flowWithLifecycle로 onEach 사용하면 되는건가..?

이게 실패했을때 스와이프로 재시도했을경우 인가요?
그렇다면 다시 서버통신할때 UiState를 loading 상태로 변경하고 값이 떨어진다면 success or failure로 갈테니 해결할 수 있습니둥

b1urrrr · 2023-10-09T20:10:45Z

data/src/main/java/com/example/data/datasource/paging/LookPagingSource.kt

+    companion object {
+        const val LOOK_PAGE_SIZE = 10
+        const val LOOK_POSITION_TO_PAGE = 0.1
+    }


가독성 미쳤따이

minju1459

수고하셨습니다 !

minju1459 · 2023-10-10T02:02:49Z

app/src/main/java/com/el/yello/presentation/main/look/LookFragment.kt

+            setPullToScrollColor(R.color.grayscales_500, R.color.grayscales_700)
+        }
+        lifecycleScope.launch {
+            repeatOnLifecycle(Lifecycle.State.CREATED) {


페이징은 백그라운드에서 실행되지 않으므로 repeatOnLifecycle가 사용된 것 맞나요??

페이징은 백그라운드 쓰레드에서 실행이 됩니닷 ! 다만 이부분은 pull-to-refresh를 설정하는 과정에서 launchWhenCreated의 용도로 사용했습니다

Lifecycle.StateSTARTED 가 아닌 CREATED로 한 이유가 있을까요? 이유가 궁금해서

minju1459 · 2023-10-10T02:07:32Z

app/src/main/java/com/el/yello/presentation/main/profile/ProfileViewModel.kt

-    private val _getState = MutableLiveData<UiState<ProfileUserModel>>()
-    val getState: LiveData<UiState<ProfileUserModel>> = _getState
+    private val _getUserDataState = MutableStateFlow<UiState<ProfileUserModel>>(UiState.Empty)
+    val getUserDataState: StateFlow<UiState<ProfileUserModel>> = _getUserDataState.asStateFlow()


asStateFlow()를 쓰지 않아두 상관은 없다고 배웠는데 혹시 쓰신 이유가 따로 있을까요??

아뇨..! ㅋㅋㅋㅋㅋㅋ 일단 쓰다보니깐 그냥 쓰고 있었네여 ..

minju1459 · 2023-10-10T02:08:50Z

app/src/main/java/com/el/yello/presentation/main/yello/YelloViewModel.kt

-    private val _getPurchaseInfoState = MutableLiveData<UiState<ResponsePurchaseInfoModel?>>()
-    val getPurchaseInfoState: LiveData<UiState<ResponsePurchaseInfoModel?>> = _getPurchaseInfoState
+    private val _getPurchaseInfoState = MutableLiveData<UiState<PayInfoModel?>>()
+    val getPurchaseInfoState: LiveData<UiState<PayInfoModel?>> = _getPurchaseInfoState


entity가독성이 좋네요 ,,!

kkk5474096

flow 생명주기 알도록 변경해주세용

kkk5474096 · 2023-10-11T00:56:37Z

app/src/main/java/com/el/yello/presentation/main/look/LookFragment.kt

+            setPullToScrollColor(R.color.grayscales_500, R.color.grayscales_700)
+        }
+        lifecycleScope.launch {
+            repeatOnLifecycle(Lifecycle.State.CREATED) {


Lifecycle.StateSTARTED 가 아닌 CREATED로 한 이유가 있을까요? 이유가 궁금해서

kkk5474096 · 2023-10-11T01:15:12Z

app/src/main/java/com/el/yello/presentation/main/profile/info/ProfileFragment.kt

-                    adapter.addItemList(friendsList)
-                }
+        lifecycleScope.launch {
+            viewModel.getFriendListState.collectLatest { state ->


flow는 뷰의 생명주기를 알지 못합니다
그래서 전에는 repeatOnLifeCycle 에서 started를 사용해서 구현했었는데
flowWithLifeCycle이라는 확장함수가 위에 내용을 담고 있어서 flowWithLifeCycle을 사용하고 있습니다.

추가로 LiveData는 Android에서 나온 라이브러리로 뷰의 생명주기를 알고 있어서 위와 같은 작업이 필요 없었죠

kkk5474096 · 2023-10-11T01:17:16Z

app/src/main/java/com/el/yello/presentation/main/profile/info/ProfileFragment.kt

-                            viewModel.myTotalFriends.value =
-                                viewModel.myTotalFriends.value?.toInt()?.minus(1).toString()
+        lifecycleScope.launch {
+            viewModel.deleteFriendState.collectLatest { state ->


위 내용과 동일합니다
lifeCycle이 종료되어도 계속 수집해서 메모리 누수가 있을수 있어용

…into mod/#266-flow-paging3

Marchbreeze added 30 commits September 19, 2023 18:26

[FIX/#266] 내쪽지 amplitude 함수화

196ad69

[MOD/#266] 타임라인 뷰 domain 레이어 설정

a87a53f

[MOD/#266] 타임라인 뷰 데이터 레이어 분리

6134af7

[MOD/#266] 타임라인 뷰 페이징 flow 설정

e109455

[FIX/#266] 타임라인 loading 수정

7918c15

[FIX/#266] 타임라인 뷰 loading StateFlow로 변경

aca1a6f

[FIX/#266] 타임라인 뷰 페이징에 shimmer 재적용

ba2b55b

Merge branch 'develop' of https://github.com/team-yello/YELLO-Android …

ac571d6

…into mod/#266-flow-paging3

[FIX/#266] 타임라인 뷰 paging size 상수화

b9ef3bb

Merge branch 'develop' of https://github.com/team-yello/YELLO-Android …

41ebbd7

…into mod/#266-flow-paging3

[FIX/#266] 타임라인 뷰 clipToPadding 설정

8fadbcb

[FEAT/#266] 타임라인 뷰 UiState 제거 후 페이징3 전환

0f8de77

[FIX/#266] 친구 0명 뷰일때 shimmer 제거

3eb6956

[FIX/#266] 타임라인 뷰 바텀 패딩 재설정

def608c

[MOD/#266] Billing Util 뷰 Flow로 변경

c734faf

[FIX/#266] Pay 뷰 함수화 진행

cfcc588

[FIX/#266] Pay 뷰 ticketCount 뷰모델로 설정

df5f989

[FIX/#266] domain 레이어 model 이름 통일

dfd88c0

[FIX/#266] Pay 뷰 모두 StateFlow로 수정

cbebd37

[MOD/#266] Search 뷰 Flow로 변경

972b3d0

[MOD/#266] Search 뷰 adapter 수정

07a9e7e

[MOVE/#266] search와 recommend 뷰 분리

57b9dad

[MOD/#266] Search 뷰의 data, domain 레이어 분리

f3d567e

[MOD/#266] Recommend와 Search 완전 분리

0d4b28e

[ADD/#266] Search 뷰 Di 레이어 적용

fd8170b

[MOD/#266] Search 뷰 PagingSource로 변경

9ef6e6b

[MOD/#266] Search 뷰 PagingSource로 변경

2dfd6ea

[MOD/#266] Search 뷰 DataSource 삭제

fd46f98

[FIX/#266] Search 뷰 Activity 적용

e6df00d

[FIX/#266] Search 뷰 어댑터 반영 시점 변경

e2dd5c0

Marchbreeze added 10 commits October 9, 2023 00:04

[FIX/#266] Search 뷰 Paging 적용 롤백 ...

a46bb4d

[FIX/#266] Search 뷰 Flow 수정

ff7df97

[FIX/#266] MyYello 뷰 fadeIn 수정

52f74f3

[FIX/#266] Pay 뷰모델 리팩토링

15c2391

[MOD/#266] Profile 뷰 유저 정보 객체화

093f752

[MOD/#266] Profile 뷰 클릭된 유저 정보 객체화

1ee1383

[FIX/#266] Profile 뷰 isSearchViewShowed 값 수정

95e431c

[MOD/#266] Recommend School 뷰에 StateFlow 적용

cf20471

[MOD/#266] Recommend Kakao 뷰에 StateFlow 적용

2b869b2

[MOD/#266] Profile 뷰에 StateFlow 적용

d7024ad

Marchbreeze added MOD ✅ 코드 수정 및 내부 파일 수정 PULL REQUEST 🚀 pull reqeust 날리기 상호 🍀 Sangho's Task labels Oct 9, 2023

Marchbreeze added this to the 코드 리팩토링 milestone Oct 9, 2023

Marchbreeze self-assigned this Oct 9, 2023

Marchbreeze requested a review from a team as a code owner October 9, 2023 11:13

b1urrrr approved these changes Oct 9, 2023

View reviewed changes

minju1459 approved these changes Oct 10, 2023

View reviewed changes

kkk5474096 requested changes Oct 11, 2023

View reviewed changes

Merge branch 'develop' of https://github.com/team-yello/YELLO-Android …

c67f28d

…into mod/#266-flow-paging3

kkk5474096 approved these changes Oct 12, 2023

View reviewed changes

Marchbreeze merged commit 2a4425c into develop Oct 12, 2023
1 check passed

b1urrrr deleted the mod/#266-flow-paging3 branch October 19, 2023 15:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MOD/#266] 추천, 검색, 프로필, 결제, 타임라인 / StateFlow로 변경 #294

[MOD/#266] 추천, 검색, 프로필, 결제, 타임라인 / StateFlow로 변경 #294

Marchbreeze commented Oct 9, 2023 •

edited

Loading

b1urrrr left a comment

b1urrrr Oct 9, 2023

Marchbreeze Oct 10, 2023

kkk5474096 Oct 11, 2023

b1urrrr Oct 9, 2023

Marchbreeze Oct 10, 2023

kkk5474096 Oct 11, 2023

b1urrrr Oct 9, 2023

Marchbreeze Oct 10, 2023

b1urrrr Oct 9, 2023

b1urrrr Oct 9, 2023

Marchbreeze Oct 10, 2023

b1urrrr Oct 9, 2023

Marchbreeze Oct 10, 2023

kkk5474096 Oct 11, 2023

b1urrrr Oct 9, 2023

Marchbreeze Oct 10, 2023

minju1459 left a comment

minju1459 Oct 10, 2023

Marchbreeze Oct 10, 2023

kkk5474096 Oct 11, 2023

minju1459 Oct 10, 2023

Marchbreeze Oct 10, 2023

minju1459 Oct 10, 2023

kkk5474096 left a comment

kkk5474096 Oct 11, 2023

kkk5474096 Oct 11, 2023

kkk5474096 Oct 11, 2023

kkk5474096 Oct 11, 2023

		fun getLookListWithPaging(): Flow<PagingData<LookModel>> {
		return lookRepository.getLookList()

[MOD/#266] 추천, 검색, 프로필, 결제, 타임라인 / StateFlow로 변경 #294

[MOD/#266] 추천, 검색, 프로필, 결제, 타임라인 / StateFlow로 변경 #294

Conversation

Marchbreeze commented Oct 9, 2023 • edited Loading

⛳️ Work Description

📢 To Reviewers

b1urrrr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

minju1459 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kkk5474096 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Marchbreeze commented Oct 9, 2023 •

edited

Loading