Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”ฅ Improve: List ์ปดํฌ๋„ŒํŠธ ๋‚ด๋ถ€์—์„œ Blank ๋ Œ๋”๋ง #60

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

a-honey
Copy link
Member

@a-honey a-honey commented Jan 14, 2025

๐ŸŒŒ Linked Out Admin Page Pull Request

โœจ Summary

์™ธ๋ถ€์—์„œ ๋ฐฐ์—ด ๊ธธ์ด ์กฐ๊ฑด๋ถ€ ๋ Œ๋”๋ง => List ์ปดํฌ๋„ŒํŠธ ๋‚ด๋ถ€์—์„œ ์ฒ˜๋ฆฌํ•˜๋„๋ก ๋ณ€๊ฒฝ

๐Ÿ”— Related Issues

๐Ÿ”จ Changes

  • ์œ ํšจํ•œ children์ด ์—†๋Š” ๊ฒฝ์šฐ, RowContainer ๋‚ด๋ถ€์—์„œ ์ปดํฌ๋„ŒํŠธ๋ฅผ ๋ฐ˜ํ™˜
  • hasValidChildren ์œ ํ‹ธ๋ฆฌํ‹ฐ ํ•จ์ˆ˜๋กœ children์˜ ์œ ํšจ์„ฑ ๊ฒ€์‚ฌ

๐Ÿ’ฌ Additional Notes

React.Children.toArray๋ฅผ ํ†ตํ•ด ๋ฐฐ์—ด๋กœ ๋งŒ๋“  ํ›„ ์œ ํšจ node ์ฒดํฌ

@a-honey a-honey self-assigned this Jan 14, 2025
@a-honey a-honey added Domain: Admin size: small ํ•œ๋‘ ๊ฐœ์˜ ๊ธฐ๋Šฅ์„ ๋ณ€๊ฒฝํ•˜๊ฑฐ๋‚˜ ์ž‘์€ ๋ฒ„๊ทธ ์ˆ˜์ • labels Jan 14, 2025
@a-honey a-honey merged commit 0aff9f6 into main Jan 14, 2025
2 checks passed
@a-honey a-honey deleted the fix/list branch January 14, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Domain: Admin size: small ํ•œ๋‘ ๊ฐœ์˜ ๊ธฐ๋Šฅ์„ ๋ณ€๊ฒฝํ•˜๊ฑฐ๋‚˜ ์ž‘์€ ๋ฒ„๊ทธ ์ˆ˜์ •
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant