Fixed Keycap

teacat · Dec 22, 2022 · ac4872b · ac4872b
1 parent 3e6703b
commit ac4872b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/search.go b/search.go
@@ -86,7 +86,7 @@ func FindAll(input string) (detectedEmojis SearchResults) {
 			continue
 		}
 
-		//
+		// NOTE:https://github.com/tmdvs/Go-Emoji-Utils/issues/12
 		if index-1 >= 0 && isDecoratorUnicode(runes[index-1]) {
 			continue
 		}
@@ -96,7 +96,9 @@ func FindAll(input string) (detectedEmojis SearchResults) {
 
 		// Ignore any basic runes, we'll get funny partials
 		// that we dont care about
-		if len(hexKey) < 4 {
+		//
+		// NOTE: 31-FE0F-20E3 1️⃣ Keycap Digit, https://github.com/tmdvs/Go-Emoji-Utils/issues/5
+		if len(hexKey) < 2 {
 			continue
 		}
 

diff --git a/tests/search_test.go b/tests/search_test.go
@@ -26,12 +26,13 @@ func BenchmarkComplexSearch(b *testing.B) {
 
 func TestRemoveAllEmoji(t *testing.T) {
 
-	str := "This is a string 😄 🐷 with some 👍🏻 🙈 emoji! 🐷 🏃🏿‍♂️ 🥰"
+	str := "This is a 1️⃣string 😄 🐷 with some 👍🏻 🙈 emoji! 🐷 🏃🏿‍♂️ 🥰"
 
 	matches := emojiutils.FindAll(str)
 	totalUniqueEmoji := len(matches)
+	log.Println(matches)
 
-	assert.Equal(t, 6, totalUniqueEmoji, "There should be six different emoji")
+	assert.Equal(t, 7, totalUniqueEmoji, "There should be six different emoji")
 
 	emojiRemoved := emojiutils.RemoveAll(str)
 	assert.Equal(t, "This is a string with some emoji!", emojiRemoved, "There should be no emoji")