Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I'm adding support for
WKWebView
so that my app supportsiOS 7
andiOS 8
at the same time, I found it's possible to add most of my changes on the app side, mostly including handlingjockey://event/xxx
messages with my own code. Surely it would be good to add this toJockey
but it will involve some interface changes. Anyhow, the only change I need to made toJockey
is the+ (void)send:(NSString *)type withPayload:(id)payload toWebView:(UIWebView *)webView
call. When I need to send from app to web, the receiver has to be aUIWebView
. So I added minimal modification by making it's possible to pass aWKWebView
as aUIWebView
(of course in this case either a protocol should be created or the type should be simply changed toid
, but I don't want to change too much to exisitingJockey
).Cheers.