Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(args): add gateway param & update tests #16

Merged
merged 2 commits into from
Apr 8, 2024
Merged

fix(args): add gateway param & update tests #16

merged 2 commits into from
Apr 8, 2024

Conversation

tchapacan
Copy link
Owner

@tchapacan tchapacan commented Apr 6, 2024

Description

Purpose of this PR is to add an optional arg to the cli, the gateway ip address of the livebox to be used. In case some users have a custom gateway (different than 192.168.1.1 default value), then an optional custom one can be supplied as args.

Fixing and aligning semver as well

Fix: #4

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test update
  • Dependencies update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@tchapacan tchapacan force-pushed the fix/4 branch 2 times, most recently from 345ddb5 to 428ef7b Compare April 6, 2024 20:31
@tchapacan tchapacan requested a review from drkaine April 6, 2024 20:32
@tchapacan tchapacan force-pushed the fix/4 branch 2 times, most recently from 90a0880 to bba9ebe Compare April 6, 2024 20:51
@drkaine drkaine merged commit 9f9fe92 into main Apr 8, 2024
1 check passed
@tchapacan tchapacan deleted the fix/4 branch April 10, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add optional argument for custom livebox ip
2 participants