-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to macos-14 runner image #169
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
=======================================
Coverage 98.06% 98.06%
=======================================
Files 69 69
Lines 2424 2424
=======================================
Hits 2377 2377
Misses 47 47 ☔ View full report in Codecov by Sentry. |
Let's see if (a) it works, and (b) it speeds up our Mac CI https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/
b4b15ff
to
8d7d631
Compare
Let's see if Clang works correctly
b246d00
to
5ff9ef9
Compare
Unfortunately it looks like there's a problem with linking executables built with GCC 13:
I don't know if this is an Apple bug in their linker, a GCC bug in the compiler, or a Homebrew bug in the way they build GCC13 on Arm... On the plus side, once this is fixed then it looks like the macos-14 image is very much faster than the Intel macos-latest image, plus it will be good to test on a different architecture as well. |
This reverts commit 5ff9ef9.
Hopefully fixes the GCC13 linker issue
It seems to cause problems with GCC on M1 macs
Let's leave this for now |
Let's see if (a) it works, and (b) it speeds up our Mac CI
https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/