Remove Build2 build system #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every so often I get very enthusiastic about Build2, with its tightly integrated package management, amazing CI and (at one time) leading support for modules. Unfortunately, soon after, reality sets in, and the impregnable buildscript syntax, steep learning curve and lack of IDE support means I go back to using CMake. So it was when I was first starting Flux -- I added Build2 support alongside CMake. Since then, I haven't really touched it and it's highly unlikely it works today. We really shouldn't pretend to support something that is completely unmaintained and probably doesn't work, so let's remove it. If someone wants to add Build2 support again later and commit to maintaining it, I'd be happy to accept pull requests.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
=======================================
Coverage 97.98% 97.98%
=======================================
Files 66 66
Lines 2383 2383
=======================================
Hits 2335 2335
Misses 48 48 ☔ View full report in Codecov by Sentry. |
tcbrindle
added a commit
that referenced
this pull request
Jan 14, 2024
This should have been removed as part of #148
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every so often I get very enthusiastic about Build2, with its tightly integrated package management, amazing CI and (at one time) leading support for modules. Unfortunately, soon after, reality sets in, and the impregnable buildscript syntax, steep learning curve and lack of IDE support means I go back to using CMake.
So it was when I was first starting Flux -- I added Build2 support alongside CMake. Since then, I haven't really touched it and it's highly unlikely it works today. We really shouldn't pretend to support something that is completely unmaintained and probably doesn't work, so let's remove it.
If someone wants to add Build2 support again later and commit to maintaining it, I'd be happy to accept pull requests.