Fix missing reverse_adaptor constraints #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
==========================================
- Coverage 97.99% 97.98% -0.01%
==========================================
Files 66 66
Lines 2389 2383 -6
==========================================
- Hits 2341 2335 -6
Misses 48 48 ☔ View full report in Codecov by Sentry. |
|
Woo, ICEs in two different compilers at once, this must be a good commit... |
This is way more than we need to actually fix the bug, but better safe than sorry. Fixes #143
Going "all in" with constraint checks works fine with GCC 12+ and Clang, but causes an ICE in GCC 11.3 and some sort of strange error in MSVC that I haven't worked out yet. So let's roll back some of the changes -- while still retaining enough to fix the original bug -- and see what happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143