Make splitting more generic #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than a pattern, `split_adaptor` now takes a "Splitter", a function object which, when passed a sequence, returns the bounds of the next slice. This opens the door to potentially doing more sophisticated splitting, for example using a (CTRE?) regex or one of the standard library searchers. At the moment, we don't publicly expose the generic Splitter interface, but this could be done in future. Rather, our existing `split()` overloads have been changed to use new (internal) `pattern_splitter` and `delim_splitter` implementations.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
==========================================
+ Coverage 97.71% 97.98% +0.27%
==========================================
Files 67 66 -1
Lines 2402 2380 -22
==========================================
- Hits 2347 2332 -15
+ Misses 55 48 -7 ☔ View full report in Codecov by Sentry. |
We split every time the predicate returns true, i.e.
split("two spaces -> <-", ::isspace)
would yield ["two", "spaces", "->", "", "<-"], with an empty sequence between the arrows.
Not sure how long this has been broken for, ooops...
If you pass equal() two sequences-of-sequences which are not directly equality comparable, but whose inner sequence types *are* comparable, then it will recursively call itself to compare the inner sequences. This is actually pretty neat.
...and likewise, size() and usize(). These can be useful with sequences that produce rvalue subsequences, like split().
And a long old example, too
When its parent sequence is bounded, anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than a pattern,
split_adaptornow uses a "Splitter", a function object which, when passed a sequence, returns the bounds of the next slice.This opens the door to potentially doing more sophisticated splitting, for example using a (CTRE?) regex or one of the standard library searchers.
At the moment, we don't publicly expose the generic Splitter interface, but this could be done in future. Rather, our existing
split()overloads have been changed to use new (internal)pattern_splitteranddelim_splitterimplementations.