Update staging/sm #4354
Merged
Update staging/sm #4354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Dec 17, 2024
test/staging/sm/Error/isError.js
Outdated
Comment on lines
1
to
7
| // Copyright (C) 2024 Mozilla Corporation. All rights reserved. | ||
| // This code is governed by the BSD license found in the LICENSE file. | ||
|
|
||
| /*--- | ||
| features: | ||
| - Error.isError | ||
| includes: [sm/non262-shell.js, sm/non262.js] |
There was a problem hiding this comment.
this file isn't needed, because these tests already exist in the main corpus
|
This is the result of running the import again after incorporating downstream feedback in the upstream SM copy of these tests? I think we should just merge it; ideally we'd automate this process in the future just like the V8 bot. Any objections if I go ahead and do that? Maybe the |
|
Likely needs to be rebased after #4368. |
ptomato
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4346
Closes #4347
Closes #4356