Editorial: Add %GeneratorPrototype% and %AsyncGeneratorPrototype% well-known intrinsics (#3230)

[arai-a]

This supersedes #3234

This is effectively same as #3234, but in order to avoid the readability issue, added dedicate well-known intrinsics for Generator prototype and Async generator prototype, that's used in the same way as %SetIteratorPrototype%.

• All occurrences of "Generator Prototype" and "Generator.prototype" are replaced with %GeneratorPrototype%
• All occurrences of "AsyncGenerator Prototype" and "AsyncGenerator.prototype" are replaced with %AsyncGeneratorPrototype%
• Related ids are updated, with moving the old ids into oldids attribute
• Also tweaked the description of Generator and AsyncGenerator to avoid the confusion from "instance of"+"generator function"

[ljharb]

We generally are trying not to add any more top-level intrinsics, but I agree this might improve readability.

[michaelficarra]

This will also have to update figure 6: https://tc39.es/ecma262/#figure-2

[arai-a]

This will also have to update figure 6: https://tc39.es/ecma262/#figure-2

Just to make sure, it's is the following parts, right?

• %GeneratorFunction.prototype.prototype% in the green box at the middle-right
  • technically this is still correct, but adding %GeneratorPrototype% in the box can make it clearer
• "... to its generator function's instances" in the pink box at the bottom-center
  • replace with "... to generators created by calling its generator function", for clarity

The following seems to be slightly unclear, but it matches to other parts:

• "abstract constructor of Generator instances" in the pink box at the middle-center
  • "Generator" and "Generator instances" are used in the same meaning. Generator Objects's 2nd paragraph also mentions "Generator instances"
  • maybe replace with "abstract constructor of generators" ?

Then, there seems to be no SVG file.
I'm happy to create a new one if necessary.

[michaelficarra]

@arai-a The source for that image is at https://github.com/tc39/ecma262/blob/main/figure-2.uxf

[arai-a]

I tried modifying the figure-2.uxf file, but that format doesn't seem to preserve the font face across environments,
and I cannot generate an equivalent PNG file.

I use UMLet 15.1 downloaded from https://www.umlet.com/index.html on Linux (Ubuntu).
The font it's using on my environment seems to be different than the current PNG file's one, and the text overflows from the box.
I can modify the box size and line wrapping to make it "good" on my environment, and then generate PNG file, but the uxf file won't look good on other environments.

What should I do?
I'm leaning toward replacing it with SVG, that's more portable...

[michaelficarra]

Replacing it with an SVG is also fine. If you do, please do so as a separate PR.

[arai-a]

Updated the SVG figure, replacing %GeneratorFunction.prototype.prototype% with %GeneratorPrototype%, and also tweaking the layout to make it centered again (it's shifted by #3239 to make the content fit)

[michaelficarra]

I think the new section IDs are mostly unnecessary and just bloat the document with oldids. Otherwise LGTM.

[arai-a]

reverted ids, and updated %AsyncGeneratorFunction% description

[jmdyck]

Looks okay to me.

[arai-a]

I'm not sure what happened, but "1 change requested" is still there.
I don't see any unresolved comment.

[jmdyck]

Apparently, resolving all comments doesn't make "1 change requested" go away. Instead, the change-requesting review must be either dismissed or replaced with an approval.