Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: fix formatting of note step in DayFromYear #3203

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Editorial: fix formatting of note step in DayFromYear #3203

merged 1 commit into from
Jan 25, 2024

Conversation

michaelficarra
Copy link
Member

Alternative to #3183, as discussed in editor call. Fixes #3180. Closes #3183.

@bakkot
Copy link
Contributor

bakkot commented Oct 18, 2023

I'm not opposed, though I still prefer the original solution. I would prefer the note remain above the steps it's talking about, though; the declared escape hatch will silence ecmarkup's complaints about that.

@michaelficarra michaelficarra added editor call to be discussed in the next editor call and removed editor call to be discussed in the next editor call labels Jan 17, 2024
@bakkot bakkot added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Jan 24, 2024
@ljharb ljharb merged commit a88ef72 into main Jan 25, 2024
8 checks passed
@ljharb ljharb deleted the GH-3180 branch January 25, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rendering issue ("_numYearsN_") in DayFromYear
4 participants