-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New cmake branch #74
New cmake branch #74
Conversation
appveyor build fails, but I do not think I'm responsible.... |
I'm very cuirous about this, thanks! |
I restarted the appveyor build. |
Some options are also missing. |
Why did you introduce matio_noreturn.h? If there is no need to touch it, please keep it as it is. |
To factor this piece of code between the matio_pubconf.h.in and matio_pubconf_cmake.in. In this way the two files only contain defines (and includres). It is also simpler to check the correspondance between the defined variables (which by the way I need to check if there were updates in this respact since I did the original cmake port). |
I still prefer to have a single pubconfig file and not distributed config files. |
5 similar comments
On MSVC I get an error that the folder |
Ok, I found a simple
Are there extra libraries that need to be linked on Windows? The cmake-generated |
Please consider PR #75 that addresses several of the above problems. |
I just pushed the one from OpenMEEG-matio... It should work out of the box as we regularly build this version of matio on windows... |
…void export macro for autoconf builds.
d982732
to
5dfe2db
Compare
Is this still being worked on? If not, I propose to close it w/o merge? |
4ff7b1e
to
4f964f8
Compare
3846a94
to
0904d31
Compare
b97f68d
to
be83cfb
Compare
622a081
to
aefd09e
Compare
Doing so. |
This is only WIP for now. All comments accepted !
The cmake build system is added. I verified it build both in old fashion and with cmake.
Tests with cmake are currently both incomplete (2018 tests instead of 3152) and sometimes wrong (180 tests out of 2018 are failing). I'm working on it.