Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18nIgnore]: flag pages as i18nReady #3177

Merged
merged 2 commits into from
Feb 22, 2025
Merged

[i18nIgnore]: flag pages as i18nReady #3177

merged 2 commits into from
Feb 22, 2025

Conversation

GuoJikun
Copy link
Contributor

@GuoJikun GuoJikun commented Feb 22, 2025 •
edited
Loading

Description

Add i18nReady flag.

closed: #3174

It can help users to know if the document is out of date by using translate-status

@GuoJikun GuoJikun requested a review from a team as a code owner February 22, 2025 07:20
@netlify Netlify
Copy link

netlify bot commented Feb 22, 2025 •
edited
Loading

✅ Deploy Preview for tauri-v2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bf889bb
🔍 Latest deploy log https://app.netlify.com/sites/tauri-v2/deploys/67b97d835afddb00092cce69
😎 Deploy Preview https://deploy-preview-3177--tauri-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@GuoJikun GuoJikun changed the title Add i18nReady flag [i18nIgnore]: Add i18nReady flag Feb 22, 2025
vasfvitor
vasfvitor approved these changes Feb 22, 2025
View reviewed changes
Copy link
Contributor

@vasfvitor vasfvitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhhh that's why. Great, ty

@vasfvitor vasfvitor changed the title [i18nIgnore]: Add i18nReady flag [i18nIgnore]: flag pages as i18nReady Feb 22, 2025
@vasfvitor vasfvitor merged commit 523cc4a into tauri-apps:v2 Feb 22, 2025
9 checks passed
@GuoJikun GuoJikun deleted the add-i18nReady-flag branch February 23, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasfvitor vasfvitor vasfvitor approved these changes

Assignees

@GuoJikun GuoJikun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[lunaria] missing pages
2 participants
@GuoJikun @vasfvitor