Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix command to create next app using bun #2077

Closed
wants to merge 1 commit into from

Conversation

zeybek
Copy link

@zeybek zeybek commented Apr 19, 2024

What kind of changes does this PR include?

  • Minor content fixes (broken links, typos, etc.)
  • Changes to the docs site code

Description

  • What does this PR change? Give us a brief description.
    It will fix typo in command to create next app with bun
  • Did you change something visual?
    No

@zeybek zeybek requested a review from a team as a code owner April 19, 2024 14:07
Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for tauri ready!

Name Link
🔨 Latest commit 4a8a8a0
🔍 Latest deploy log https://app.netlify.com/sites/tauri/deploys/66227aa04c148100087de4f5
😎 Deploy Preview https://deploy-preview-2077--tauri.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@vasfvitor vasfvitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi this was recently changed in #2041, did bun changed the command again? Could you share where/when they changed, and, if any, announcement?

bunx create next-app --use-bun Still works for me.

https://bun.sh/guides/ecosystem/nextjs

@zeybek
Copy link
Author

zeybek commented Apr 19, 2024

Hi this was recently changed in #2041, did bun changed the command again? Could you share where/when they changed, and, if any, announcement?

bunx create next-app --use-bun Still works for me.

https://bun.sh/guides/ecosystem/nextjs

hi @vasfvitor, I'm currently using [email protected] and existing command for bun is not working, to make it work we can use one of the following commands

  • bun create next-app
  • bunx create-next-app

@zeybek zeybek requested a review from vasfvitor April 19, 2024 14:55
@vasfvitor
Copy link
Contributor

image
image

@vasfvitor
Copy link
Contributor

if this is a platform difference (I'm on Windows) please share the source where we can verify this to be the case

@zeybek
Copy link
Author

zeybek commented Apr 19, 2024

@vasfvitor I'm on MacBook Pro M1 and Sonoma 14.3.1 has been installed, also as we can see on NextJS official documentation, command has been given as bunx create-next-app, please check here and here

Btw, it is weird that you can run bunx with create next-app since it is equivalent of npx

@dreyfus92
Copy link
Member

if this is a platform difference (I'm on Windows) please share the source where we can verify this to be the case

It might be a platform thing I've tested both and the new command works me, the older doesn't. Also note I'm as well on macOS 😁

@simonhyll
Copy link
Contributor

image

image

No screenshot for Mac but I tried it on my work Sonoma 14.1 Mac and the results are the same.

The existing one works, bun create next-app --use-bun, the proposed one doesn't. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants