Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(stop-retrying): clarify different between attemptMade and attemptsStarted #3003

Merged
merged 1 commit into from
Jan 11, 2025
Merged

docs(stop-retrying): clarify different between attemptMade and attemptsStarted #3003

merged 1 commit into from
Jan 11, 2025

Conversation

roggervalf
Copy link
Collaborator

Why

  1. Why is this change necessary? We should clarify the difference between attemptMade and attemptStarted and when they can be used

How

  1. How did you implement this? Fix example in our documentation and add a info section to clarify these concepts

Additional Notes (Optional)

ref #3000

manast
manast approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@manast manast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roggervalf roggervalf merged commit 14c9fed into master Jan 11, 2025
11 checks passed
@roggervalf roggervalf deleted the docs-stop-retrying-fix branch January 11, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manast manast manast approved these changes

Assignees
No one assigned
Labels
better docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roggervalf @manast