Fix/avoid hazards when upserting job schedulers #2892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
force-pushed
the
fix/avoid-hazards-when-upserting-job-schedulers
branch
from
9d086ee to
937b8f8
Compare
roggervalf
reviewed
Nov 11, 2024
…ps://github.com/taskforcesh/bullmq into fix/avoid-hazards-when-upserting-job-schedulers
roggervalf
approved these changes
Nov 11, 2024
| @@ -268,3 +295,13 @@ export const defaultRepeatStrategy = ( | |||
| // Ignore error | |||
| } | |||
| }; | |||
|
|
|||
| function removeUndefinedFields(obj: Record<string, any>) { | |||
There was a problem hiding this comment.
This is a duplicated method. It's added in utils but it was not removed from here
| @@ -464,11 +465,11 @@ export class Job< | |||
| * @returns | |||
| */ | |||
| asJSON(): JobJson { | |||
| return { | |||
| return removeUndefinedFields<JobJson>({ | |||
There was a problem hiding this comment.
ok I get the intention, what if instead of iteration yo all these option at the end, do something like
const jobJson = {
id: this id,
// all the other attributes that don't be unfefined
};
if(this parent) {
jobJson.parent = this.parent;
}
// same idea with the other atrributesThere was a problem hiding this comment.
Because it is easier to forget and it will be more code to maintain. I discovered that we have a lot of empty fields which just consume space for no reason before I added this feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2876