Feat/better handling of queue markers #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Markers use now a dedicated key in redis instead of using a special Job ID.
roggervalf
force-pushed
the
feat/better-handling-of-queue-markers
branch
from
0bac0fb to
f87e88b
Compare
BREAKING CHANGE: Markers use now a dedicated key in redis instead of using a special Job ID.
roggervalf
force-pushed
the
feat/better-handling-of-queue-markers
branch
from
f87e88b to
73cf5fc
Compare
1 task
BREAKING CHANGE unify redis connection args for Queue and Worker
…gers (#2312) BREAKING CHANGE throw error when custom job ids represent integers
roggervalf
force-pushed
the
feat/better-handling-of-queue-markers
branch
from
9a9a0b7 to
5ea405d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new mechanism for handling queue markers which results in a simpler implementation and addresses issues like thes ones: #2268 #2286
However as it introduces a new key it is also a breaking change and all workers should be upgraded to this new version at once to avoid any issues.
https://bullmq.io/news/231204/better-queue-markers/#migrating-from-v4-to-v5