-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add custom theming #69
Conversation
@miraclx @rafi Check out this PR. I've added the ability to specify a custom theme in the config file. If no theme is found, it'll default to your terminal colors no different than before. Here are my colors, try adding the following.
So it is preferable that you don't use the
|
Also, I tried not to go overboard on the number of color options. I think most of them make sense, but I'm open to suggestions on changing the names / configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pointing out some visual differences in the defaults
Ahh good catches. My theme had Cyan and LightCyan the same, so I never noticed this difference. I don't really see the need to have 2 slight variations of the same color, especially now as it'd be an additional theme color that needs to be specified. |
I agree though, best to keep things simple yet configurable. In a sense, the color standardization actually looks better. |
partially resolves #65