Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in python version check #56

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

ealong
Copy link

@ealong ealong commented Apr 27, 2020

Same bug present in Issue #51 - does not accurately check for 3.5+.

if sys.version_info[0] < 3 or (sys.version_info[0] > 3  and sys.version_info[1] < 5) :
		return False
return True

Returns True for all versions of Python 3 and (would return) False for versions 4.0-4.4.

@feghalya
Copy link
Collaborator

Good catch. Merging now.

@feghalya feghalya merged commit a4945ac into tariqdaouda:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants