feat: add basic cucumber tests #254
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added cucumber tests
- basic framework
clash with
```
error[E0277]: `Rc<UnsafeCell<ReseedingRng<rand_chacha::chacha::ChaCha12Core, OsRng>>>` cannot be sent between threads safely
--> integration_tests\src\p2pool_process.rs:90:5
|
90 | task::spawn(async move {
| ^ ---------- within this `{async block@integration_tests\src\p2pool_process.rs:90:17: 90:27}`
| _____|
| |
91 | | println!(
92 | | "Initializing p2pool node: name={}; p2p_port={}; grpc_port={}; is_seed_node={}",
93 | | name_cloned, p2p_port, grpc_port, is_seed_node
... |
133 | | }
134 | | });
| |______^ `Rc<UnsafeCell<ReseedingRng<rand_chacha::chacha::ChaCha12Core, OsRng>>>` cannot be sent between threads safely
|
= help: within `{async block@integration_tests\src\p2pool_process.rs:90:17: 90:27}`, the trait `std::marker::Send` is not implemented for `Rc<UnsafeCell<ReseedingRng<rand_chacha::chacha::ChaCha12Core, OsRng>>>`, which is required by `{async block@integration_tests\src\p2pool_process.rs:90:17: 90:27}: std::marker::Send`
note: required because it appears within the type `ThreadRng`
--> C:\Users\pluto\.cargo\registry\src\index.crates.io-6f17d22bba15001f\rand-0.8.5\src\rngs\thread.rs:62:12
|
62 | pub struct ThreadRng {
| ^^^^^^^^^
note: required because it's used within this `async` fn body
--> C:\Users\pluto\Documents\Code\@tari-sha-p2pool\p2pool\src\server\p2p\network.rs:2356:56
|
2356 | async fn main_loop(&mut self) -> Result<(), Error> {
| ________________________________________________________^
```
hansieodendaal
force-pushed
the
ho_cucumber
branch
from
f21cb6b to
5d28125
Compare
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
What process can a PR reviewer use to test or verify this change?
Breaking Changes