Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated packet_source to fix bug with BlackBodySimpleSource.create_pa… #2962

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

nvieira-mcgill
Copy link
Contributor

Updated packet_source to fix bug with BlackBodySimpleSource.create_packets() to take args and kwargs

Resolves #2953

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

@tardis-bot
Copy link
Contributor

*beep* *bop*
Hi human,
I ran ruff on the latest commit (59b9500).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

1	RET505	Unnecessary `else` after `return` statement

Complete output(might be large):

tardis/transport/montecarlo/packet_source.py:246:9: RET505 Unnecessary `else` after `return` statement
Found 1 error.

@andrewfullard
Copy link
Contributor

andrewfullard commented Feb 3, 2025

Apologies for the errors. So that tests can run, please push an empty commit with git commit --allow-empty -m "Trigger workflows"

@wkerzendorf
Copy link
Member

@nvieira-mcgill can you also add yourself to mailmap

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.17%. Comparing base (34c0a4f) to head (59b9500).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
tardis/transport/montecarlo/packet_source.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2962      +/-   ##
==========================================
- Coverage   69.54%   69.17%   -0.38%     
==========================================
  Files         228      228              
  Lines       16429    16429              
==========================================
- Hits        11425    11364      -61     
- Misses       5004     5065      +61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jvshields jvshields merged commit 6e790c6 into tardis-sn:master Feb 21, 2025
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not accepting args/kwargs in BlackBodySimpleSourceRelativistic.create_packets()
5 participants