Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #2820 #2830

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fix for #2820 #2830

merged 1 commit into from
Sep 30, 2024

Conversation

atharva-2001
Copy link
Member

📝 Description

Type: 🪲 bugfix | 🚀 feature | ☣️ breaking change | 🚦 testing | 📝 documentation | 🎢 infrastructure

Changes triggers to only work for pushes and pull requests to master.

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@atharva-2001 atharva-2001 linked an issue Sep 30, 2024 that may be closed by this pull request
@tardis-bot
Copy link
Contributor

*beep* *bop*
Hi human,
I ran ruff on the latest commit (b5b2ab3).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

1	E999	SyntaxError: Expected an expression

Complete output(might be large):

.github/workflows/tests.yml:7:4: E999 SyntaxError: Expected an expression
Found 1 error.

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

The docs workflow has failed

Click here to see the build log.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.72%. Comparing base (de4d872) to head (b5b2ab3).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2830      +/-   ##
==========================================
- Coverage   70.89%   70.72%   -0.18%     
==========================================
  Files         209      209              
  Lines       15589    15589              
==========================================
- Hits        11052    11025      -27     
- Misses       4537     4564      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewfullard andrewfullard merged commit 60006d5 into tardis-sn:master Sep 30, 2024
21 of 38 checks passed
CePowers pushed a commit to CePowers/tardis that referenced this pull request Oct 1, 2024
Make sure tests only run when push to master and pull request to master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Test workflow duplicates test runs
4 participants