fix: Fix null reference exception in setter that sets DbConnection property of the TDengineCommand class. #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
var command = new TDengineCommand()
{
CommandText = "...",
CommandType = CommandType.Text,
};
var connection = new TDengineConnection("...");
command.DbConnection = connection;
如上代码片段中最后一行代码，因为 TDengineConnection 尚未打开，所以其内部的 client 变量为空，故而导致 TDegnineCommand.DbConnection 属性设置器中的代码引发了空引用异常。
现将 TDengineCommand 类中的 DbConnection 属性的设置器中的 _connection.client.StmtInit() 调用移动到 Statement() 方法中，将 StmtInit() 方法后置到执行方法也更为合理。
添加对 DbParameter.Value 为 DBNull.Value 的支持。
|
Can someone please help me with the code pull request approvals? |
|
@PopeyeZhong Can you add some unit tests to cover it? |
|
@PopeyeZhong Please rebase the 3.0 branch. |
…Query_WithDBNull 两个单元测试用例。
Okay, I've added two unit test cases for TDengineCommand, please check them:
|
YES, I just checked and it's based on the 3.0 branch. |
huskar-t
reviewed
Nov 27, 2024
Comment on lines
68
to
106
| public void SetConnection_DoesNotThrowException() | ||
| { | ||
| using(var command = new TDengineCommand()) | ||
| { | ||
| command.CommandText = "SELECT * FROM t"; | ||
| var ex = Record.Exception(() => command.Connection = _connection); | ||
| Assert.Null(ex); | ||
| } | ||
|
|
||
| using(var command = new TDengineCommand()) | ||
| { | ||
| using(var connection = new TDengineConnection("username=root;password=taosdata")) | ||
| { | ||
| command.CommandText = "SELECT * FROM t"; | ||
| var ex = Record.Exception(() => command.Connection = connection); | ||
| Assert.Null(ex); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| [Fact] | ||
| public void ExecuteNonQuery_WithDBNull() | ||
| { | ||
| using(var command = new TDengineCommand(_connection)) | ||
| { | ||
| command.CommandText = "create table if not exists t_dbnull (ts timestamp,v int,description nchar(100))"; | ||
| command.ExecuteNonQuery(); | ||
| command.CommandText = "INSERT INTO t_dbnull VALUES (?,?,?)"; | ||
| command.Parameters.AddWithValue(DateTime.Now); | ||
| command.Parameters.AddWithValue(123); | ||
| command.Parameters.AddWithValue(DBNull.Value); | ||
|
|
||
| int affectedRows = command.ExecuteNonQuery(); | ||
|
|
||
| Assert.Equal(1, affectedRows); | ||
| } | ||
| } | ||
|
|
||
| [Fact] |
Done! please check it. |
huskar-t
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
var command = new TDengineCommand()
{
CommandText = "...",
CommandType = CommandType.Text,
};
var connection = new TDengineConnection("...");
command.DbConnection = connection;
上述代码片段中最后一行代码，因为 TDengineConnection 尚未打开，所以其内部的 client 变量为空，故而导致 TDegnineCommand.DbConnection 属性设置器中的代码引发了空引用异常。
现将 TDengineCommand 类中的 DbConnection 属性的设置器中的 _connection.client.StmtInit() 调用移动到 Statement() 方法中，将 StmtInit() 方法后置到执行方法也更为合理。