-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows (MinGW) #2035
base: main
Are you sure you want to change the base?
Windows (MinGW) #2035
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the installation of MinGW you should be adding the appropriate path of the MinGW libraries to your PATH. An issue like this is most likely the runtime .dlls not available in your PATH. Did you make that step? Dependency walker is a great tool to manage and resolve those kind of issues. |
Success! I got the exe to launch after updating my PATH to include my mingw64 bin folder and my "cmake install" bin folder. Might be worth noting that in the README for troubleshooting. The next issue was that the file path to the default scene was incorrect at launch:
This was the output from launching either from Command Prompt or by clicking the exe in File Explorer. We might need to adjust the file path logic in WindowsPlatform - I don't think our Url class is able to reformat Windows-style paths. However, once I corrected the file path manually the scene loaded and rendered! 🎉 |
@matteblair @karimnaaji I've hacked around it in one of my commits, In main.cpp // Resolve the input path against the current directory.
Url baseUrl("file:///");
char pathBuffer[PATH_MAX] = {0};
if (_getcwd(pathBuffer, PATH_MAX) != nullptr) {
// URL handler apparently needs slash at end of it
strcat(pathBuffer, "/");
baseUrl = Url("file:///" + std::string(pathBuffer)).resolved(baseUrl);
} IIRC this fixed path problem for me. Of course proper fix would be better but perhaps it'd guide you to the root of the cause. |
fe6ddd2
to
3b34811
Compare
- Use glad from GLFW - Remove unsupported toolchains
- Fixup path for res folder - Remove stack protector on sqlite dependency
- Remove unused - Convert to 2 spaces tabs
- Make use of build options to disable curl tests and exe - Make use of vm cores
- Consolidate version updates to curl/zlib. - Update `-j2` by `-j %NUMBER_OF_PROCESSORS%`, appveyor VMs might have up to 4 cores.
Any progress in this PR? |
I've been sadly neglecting this PR for a long time. I had been attempting to create a "native" port that doesn't require MinGW, but it's clear that having a port of some kind is still really valuable! I'll attempt to fix the conflicts in this PR and test it again over the next week. |
Supersedes PR #1812 (thanks to @tehKaiN for the initial work on this):
curl multi API support hasn't been added yet, still TODO for that PR(added in UrlClient use curl multi api #1994).