Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping #738

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Housekeeping #738

wants to merge 24 commits into from

Conversation

Adamtaranto
Copy link
Collaborator

@Adamtaranto Adamtaranto commented Jan 5, 2025

Tidying up the codebase. Do not merge yet.

  • Find missing dependancies
  • Update misc Py3 conventions
  • Review new Ribbon module functionality
  • update lastz runner for use with Ribbon module
  • Test build on windows

@Adamtaranto Adamtaranto marked this pull request as draft January 5, 2025 07:54
@Adamtaranto Adamtaranto self-assigned this Jan 5, 2025
@Adamtaranto
Copy link
Collaborator Author

@tanghaibao was there a reason that numpy version was fixed as < 2 ?

@Adamtaranto Adamtaranto marked this pull request as ready for review January 5, 2025 07:59
@tanghaibao
Copy link
Owner

@tanghaibao was there a reason that numpy version was fixed as < 2 ?

I don't recall. Introduced in 2eae789

Maybe some weird interaction between numpy version and cython.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants