New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stringSplitter option type #158

Open

ivanrodgerapos wants to merge 1 commit into tameemsafi:main from ivanrodgerapos:master

ivanrodgerapos commented Nov 7, 2022

This pull request aims to fix stringSplitter's option type

stringSplitter option accepts a callback function with a return type of array of strings

Refer to src\core\Typewriter.js line 201

if(string) {
  const { stringSplitter } = this.options || {};
  const characters = typeof stringSplitter === 'function' ? stringSplitter(string) : string.split('');
  this.typeCharacters(characters, node);
}

Fix: change the return type delcared in index.d.ts at line 71

- stringSplitter?: (text: string) => string
+ stringSplitter?: (text: string) => string[]


          Fix stringSplitter option Type

add7680

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet