Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create zh layouts support #140

Closed
wants to merge 3 commits into from
Closed

create zh layouts support #140

wants to merge 3 commits into from

Conversation

huibizhang
Copy link
Member

No description provided.

@kayac-chang kayac-chang changed the base branch from tw to struct-modified-docs December 28, 2021 06:32
@kayac-chang kayac-chang changed the title step2. create zh layouts supportment create zh layouts support Dec 28, 2021
kayac-chang
kayac-chang reviewed Dec 28, 2021
View reviewed changes
Copy link

@kayac-chang kayac-chang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以討論看看
如何將程式碼異動降到最小
雖然有很多地方是作者直接寫死在code裡
但應該還是有辦法

這樣官方那邊假設更新東西 我們的痛苦會比較少

@huibizhang
Copy link
Member Author

可以討論看看
如何將程式碼異動降到最小
雖然有很多地方是作者直接寫死在code裡
但應該還是有辦法

這樣官方那邊假設更新東西 我們的痛苦會比較少

那你有沒有什麼覺得可以嘗試看看的方向
因為這些移出來的多半是不太會更新的部分

不過這種另外放一個檔案的麻煩，就是官方更新合進來不會影響到我們，不用一直解衝突，可是就是要看什麼東西是新的、多出來的，這點比較累

Base automatically changed from struct-modified-docs to tw January 3, 2022 08:39
@huibizhang huibizhang closed this Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayac-chang kayac-chang kayac-chang left review comments

@ashramwen ashramwen Awaiting requested review from ashramwen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huibizhang @kayac-chang