Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol): emit blob hashes in event and split meta into 2 structs #18817

Merged
merged 24 commits into from
Jan 24, 2025
Merged

feat(protocol): emit blob hashes in event and split meta into 2 structs #18817

merged 24 commits into from
Jan 24, 2025

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Jan 22, 2025 •
edited
Loading

Splitting BlockMetadata into BlockMetadata and BlockInfo to save gas in proveBatches

@dantaik dantaik requested a review from davidtaikocha January 22, 2025 07:47
@dantaik dantaik marked this pull request as ready for review January 22, 2025 07:47
@dantaik dantaik requested a review from smtmfft January 22, 2025 07:49
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Jan 22, 2025 •
edited
Loading

feat(protocol): emit blob hashes in event and split meta into 2 structs

Generated at commit: 7a8e3928417ceab74c7aa8b6fe4861a5776eaa34

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 3
3
0
10
40
56
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik requested a review from davidtaikocha January 22, 2025 13:51
@dantaik dantaik changed the title refactor(protocol): emit blob hashes in BatchProposed event feat(protocol): emit blob hashes in event and split meta into 2 structs Jan 22, 2025
@davidtaikocha davidtaikocha merged commit 7ac4087 into pacaya_fork Jan 24, 2025
5 checks passed
@davidtaikocha davidtaikocha deleted the emit_blob_hashes_in_event branch January 24, 2025 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaodino xiaodino xiaodino approved these changes

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@YoGhurt111 YoGhurt111 YoGhurt111 approved these changes

@smtmfft smtmfft Awaiting requested review from smtmfft

@AnshuJalan AnshuJalan Awaiting requested review from AnshuJalan

@cyberhorsey cyberhorsey Awaiting requested review from cyberhorsey

Assignees
No one assigned
Labels
area.protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dantaik @YoGhurt111 @davidtaikocha @xiaodino