feat(taiko-client): changes based on Pacaya fork
#18746
Open
+25,574
−2,722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtaikocha
force-pushed
the
pacaya_fork_client
branch
from
4ffcb6c to
a888655
Compare
feat(taiko-client): changes based on
|
| Severity Level | Results | |
|---|---|---|
| Contracts | Critical High Medium Low Note Total |
3 3 0 10 40 56 |
| Dependencies | Critical High Medium Low Note Total |
0 0 0 0 0 0 |
For more details view the full report in OpenZeppelin Code Inspector
davidtaikocha
force-pushed
the
pacaya_fork_client
branch
from
eea8b99 to
a1f5c27
Compare
mask-pp
reviewed
Jan 30, 2025
packages/taiko-client/driver/chain_syncer/blob/blocks_inserter/pacaya.go
Show resolved
Hide resolved
mask-pp
reviewed
Jan 31, 2025
mask-pp
reviewed
Feb 1, 2025
packages/taiko-client/driver/chain_syncer/blob/blocks_inserter/pacaya.go
Outdated
Show resolved
Hide resolved
cyberhorsey
reviewed
Feb 3, 2025
| L1BlockHeight: meta.GetRawBlockHeight(), | ||
| L1BlockHash: meta.GetRawBlockHash(), | ||
| }, | ||
| Txs: allTxs[txListCursor : txListCursor+int(blockInfo.NumTransactions)], |
There was a problem hiding this comment.
testing on our Helder devnet, if you submit a garbage block with a calldata txList and a block with numTransactions 1 (but the calldata txList is just garbage), this panics.
panic: runtime error: slice bounds out of range [:1] with capacity 0
goroutine 548 [running]:
github.com/taikoxyz/taiko-mono/packages/taiko-client/driver/chain_syncer/blob/blocks_inserter.(*BlocksInserterPacaya).InsertBlocks(0xc000a02050, {0x284d118, 0xc00052b0e0}, {0x285e560, 0xc0000fc6c8}, 0xc0018f4500, 0xc00052b0e0?)
/build/packages/taiko-client/driver/chain_syncer/blob/blocks_inserter/pacaya.go:210 +0x1dfe
Co-authored-by: Gavin “yoghurt” Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
BatchProposedevent feat(taiko-client): check if the block is preconfirmed before callingsetHead#18864