feat(taiko-client): support tier_zkvm_any
#18721
Draft
+358
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
|
|
||
| // ZKAnyProofProducer generates a ZK proof for the given block. | ||
| type ZKAnyProofProducer struct { |
There was a problem hiding this comment.
Not 100% sure but can we try to make something like this to reduce the code redundancy:
type ZKAnyProofProducer struct {
spProducer *ZKvmProofProducer
r0Producer *ZKvmProofProducer
}There was a problem hiding this comment.
Or make zkAny another option of the current ZKvmProofProducer, if its just API request body changes.
There was a problem hiding this comment.
Not sure what raiko will design their api.
Currently code change is based on adding a new api without breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.