feat: complete v3 Aggregation APIs #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Write in-memory implementation Stub out sqlite implementation
All of theses changes were commentted and discussed at taikoxyz#387 1. Remove checking of empty proof of Aggregation Cancel request. For this case, querying task status will return None, and we will response with NotFound error directly. See also taikoxyz#387 (comment) 2. Remove metrics recording to maintain consistency with v1 and v2 See also taikoxyz#387 (comment) 3. Check task status before signal cancel to prover
smtmfft
approved these changes
Dec 3, 2024
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several v3 Aggregation APIs, including Aggregation Cancel, Aggregation Report, Aggregation Prune API 👏
Note that, most of the works were done at #387 by @petarvujovic98 . This PR cherry-picks the changes from #387 and make some updates according to the latest codebase and discussion.
Here I list some differences. All of theses changes were commentted and discussed at #387 :
Remove checking of empty proof of Aggregation Cancel request.
For this case, querying task status will return None, and we will response with NotFound error directly.
Remove metrics recording to maintain consistency with v1 and v2
Check task status before signal cancel to prover
No SQLite Task Manager implementations, as it was removed by feat(taskdb): remove sqlite task manager #423