fix: fast fail for incorrect recursion mode #414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keroro520
temporarily deployed
to
test-environment
GitHub Actions
Inactive
smtmfft
reviewed
Nov 22, 2024
| @@ -109,6 +109,12 @@ impl Prover for Sp1Prover { | |||
| let param = Sp1Param::deserialize(config.get("sp1").unwrap()).unwrap(); | |||
| let mode = param.prover.clone().unwrap_or_else(get_env_mock); | |||
|
|
|||
| if matches!(param.recursion, RecursionMode::Compressed) { | |||
| return Err(ProverError::GuestError( | |||
There was a problem hiding this comment.
I think you can not do that before we have a clear flag shows it is aggregation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As SP1 prover only allows
RecursionMode::Compressedfor aggregation proving, we can reject this kind of invalid request as soon as possible.