Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prover): track cycles of sp1 guest & patch Secp256k1 #288

Merged
merged 23 commits into from
Jun 17, 2024
Merged

feat(prover): track cycles of sp1 guest & patch Secp256k1 #288

merged 23 commits into from
Jun 17, 2024

Conversation

CeciliaZ030
Copy link
Contributor

Print cycles with

$ SP1_PROVER=mock RUST_LOG=debug cargo run --features sp1

Results in nice println like this:

2024-06-11T17:27:46.899215Z DEBUG execute: ┌╴sign_recover    
2024-06-11T17:27:46.926345Z DEBUG execute: │ ┌╴sign    
2024-06-11T17:27:47.066870Z  INFO execute: │ └╴1,101,016 cycles    
2024-06-11T17:27:47.066959Z DEBUG execute: │ ┌╴recover    
2024-06-11T17:27:47.372553Z  INFO execute: │ └╴379,598 cycles    
2024-06-11T17:27:47.372628Z  INFO execute: └╴1,691,304 cycles

Included the latest optimization of cycles in https://github.com/CeciliaZ030/rust-secp256k1
Diff: https://github.com/rust-bitcoin/rust-secp256k1/compare/master...CeciliaZ030:rust-secp256k1:sp1-patch?expand=1

@CeciliaZ030 CeciliaZ030 temporarily deployed to test-environment June 11, 2024 18:26 — with GitHub Actions Inactive
@CeciliaZ030 CeciliaZ030 temporarily deployed to test-environment June 11, 2024 19:57 — with GitHub Actions Inactive
@CeciliaZ030 CeciliaZ030 requested a review from Brechtpd June 11, 2024 19:57
@CeciliaZ030 CeciliaZ030 enabled auto-merge June 11, 2024 20:01
@CeciliaZ030 CeciliaZ030 temporarily deployed to test-environment June 11, 2024 22:07 — with GitHub Actions Inactive
Brechtpd
Brechtpd reviewed Jun 11, 2024
View reviewed changes
lib/src/builder/execute.rs Outdated Show resolved Hide resolved
lib/src/builder/execute.rs Outdated Show resolved Hide resolved
lib/src/builder/execute.rs Outdated Show resolved Hide resolved
lib/src/builder/execute.rs Outdated Show resolved Hide resolved
lib/src/builder/execute.rs Outdated Show resolved Hide resolved
lib/src/builder/execute.rs Outdated Show resolved Hide resolved
lib/src/builder/mod.rs Outdated Show resolved Hide resolved
provers/sp1/guest/Cargo.toml Show resolved Hide resolved
@CeciliaZ030 CeciliaZ030 temporarily deployed to test-environment June 15, 2024 04:32 — with GitHub Actions Inactive
@CeciliaZ030 CeciliaZ030 temporarily deployed to test-environment June 15, 2024 04:36 — with GitHub Actions Inactive
@CeciliaZ030 CeciliaZ030 temporarily deployed to test-environment June 15, 2024 04:52 — with GitHub Actions Inactive
@CeciliaZ030 CeciliaZ030 temporarily deployed to test-environment June 15, 2024 04:56 — with GitHub Actions Inactive
@CeciliaZ030 CeciliaZ030 temporarily deployed to test-environment June 16, 2024 05:00 — with GitHub Actions Inactive
@CeciliaZ030 CeciliaZ030 temporarily deployed to test-environment June 16, 2024 05:04 — with GitHub Actions Inactive
@CeciliaZ030 CeciliaZ030 temporarily deployed to test-environment June 16, 2024 05:36 — with GitHub Actions Inactive
@CeciliaZ030 CeciliaZ030 added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit 927e697 Jun 17, 2024
18 of 19 checks passed
@CeciliaZ030 CeciliaZ030 deleted the sp1-cycle-opt branch June 17, 2024 03:00
@taiko-kitty taiko-kitty mentioned this pull request Jun 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brechtpd Brechtpd Brechtpd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CeciliaZ030 @Brechtpd