Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(addon-editor): hide mode and alpha, output format, input mask #353

Closed
wants to merge 1 commit into from
Closed

feat(addon-editor): hide mode and alpha, output format, input mask #353

wants to merge 1 commit into from

Conversation

KarimovDev
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Closes #352

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@KarimovDev KarimovDev force-pushed the feat-color-picker-options branch 3 times, most recently from b2e3810 to f3960b4 Compare April 25, 2021 13:15
@KarimovDev KarimovDev changed the title feat(color-picker): ability to hide mode, alpha and to change output format feat(addon-editor): hide mode and alpha, output format, input mask Apr 25, 2021
@KarimovDev KarimovDev changed the title feat(addon-editor): hide mode and alpha, output format, input mask [WiP] feat(addon-editor): hide mode and alpha, output format, input mask Apr 25, 2021
@KarimovDev KarimovDev force-pushed the feat-color-picker-options branch from f3960b4 to 311a0e3 Compare April 25, 2021 13:53
@KarimovDev KarimovDev changed the title [WiP] feat(addon-editor): hide mode and alpha, output format, input mask feat(addon-editor): hide mode and alpha, output format, input mask Apr 25, 2021
@KarimovDev KarimovDev force-pushed the feat-color-picker-options branch from 311a0e3 to ae54f96 Compare April 25, 2021 17:15
@KarimovDev
Copy link
Contributor Author

KarimovDev commented May 16, 2021 •
edited
Loading

@waterplea hi!

What do you think about this feature? It's hard to use color picker without this options. It would be so cool if we merged this )
Maybe this PR will be easy to check if I divide it into some parts?

@waterplea
Copy link
Collaborator

Yes, this is something we definitely want to make configurable, but we need to think carefully on the API and I didn't yet have time to.

@KarimovDev
Copy link
Contributor Author

Yes, this is something we definitely want to make configurable, but we need to think carefully on the API and I didn't yet have time to.

Thank you. I will wait for the PR review )

@waterplea
Copy link
Collaborator

I'm closing this as we are working on making editor tools more configurable in a completely new approach for new tiptap based editor.

@waterplea waterplea closed this Oct 18, 2021
@KarimovDev
Copy link
Contributor Author

I'm closing this as we are working on making editor tools more configurable in a completely new approach for new tiptap based editor.

Nice, we will wait for new features )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi

@nikitadubinsk nikitadubinsk Awaiting requested review from nikitadubinsk

@waterplea waterplea Awaiting requested review from waterplea

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 - color input ability to hide mode and alpha, to change output format and to provide mask
2 participants
@KarimovDev @waterplea