Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix project deps in nx.json #29

Merged
merged 1 commit into from
Jul 23, 2024
Merged

build: fix project deps in nx.json #29

merged 1 commit into from
Jul 23, 2024

Conversation

sevaru
Copy link
Contributor

@sevaru sevaru commented Jul 23, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Fixes legacy nx.json configuration for targets:

  • build
  • release

that would prevent build of deps for libraries

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Dependencies of library won't build unless the've changed

What is the new behavior?

Dependencies will build

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

nx.json uses old, deprecated targetDependencies options
switched to dependsOn field in targetDefaults
link

@sevaru sevaru requested a review from MarsiBarsi as a code owner July 23, 2024 07:12
@splincode splincode merged commit 28a5c0c into main Jul 23, 2024
3 checks passed
@splincode splincode deleted the fix-ci-build branch July 23, 2024 07:28
@taiga-family-bot
Copy link
Contributor

🎉 This pull request is included in version [email protected] 🎉

The release is available on GitHub release

@taiga-family-bot
Copy link
Contributor

🎉 This pull request is included in version [email protected] 🎉

The release is available on GitHub release

@taiga-family-bot
Copy link
Contributor

🎉 This pull request is included in version [email protected] 🎉

The release is available on GitHub release

@taiga-family-bot
Copy link
Contributor

🎉 This pull request is included in version [email protected] 🎉

The release is available on GitHub release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants