Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rewrite loadAddress in Tact and inline __tact_load_address #1895

Merged
merged 2 commits into from
Feb 18, 2025
Merged

refactor: rewrite loadAddress in Tact and inline __tact_load_address #1895

merged 2 commits into from
Feb 18, 2025
+114 −156

Conversation

anton-trunov
Copy link
Member

This saves gas.

Issue

Closes #1892.

Checklist

  • I have added tests to demonstrate the contribution is correctly implemented: it reduces gas consumption for the common cases, makes storage improvements, etc. and does not have too much negative impact for the rest of the use-cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@anton-trunov anton-trunov added this to the v1.6.0 milestone Feb 18, 2025
@anton-trunov anton-trunov requested a review from a team as a code owner February 18, 2025 16:02
@anton-trunov anton-trunov changed the title Rewrite loadAddress in Tact and inline __tact_load_address refactor: rewrite loadAddress in Tact and inline __tact_load_address Feb 18, 2025
@anton-trunov anton-trunov merged commit 3460051 into main Feb 18, 2025
26 of 27 checks passed
@anton-trunov anton-trunov deleted the inline-__tact_load_address branch February 18, 2025 17:21
i582 pushed a commit that referenced this pull request Feb 19, 2025
@anton-trunov @i582
refactor: rewrite loadAddress in Tact and inline `__tact_load_addre…
b2971e4 
…ss` (#1895)

Inlining saves gas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i582 i582 i582 left review comments

@verytactical verytactical verytactical approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Rewrite loadAddress in Tact and inline __tact_load_address
3 participants
@anton-trunov @i582 @verytactical